Djam/u-boot
1
0
Fork 0
mirror of https://github.com/u-boot/u-boot.git synced 2025-04-23 22:14:54 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

led: update LED boot/activity to new property implementation

Browse source 
Update LED boot/activity to reference by phandle instead of label and
add to period property the "-ms" suffix.
This is a followup request by dt-schema maintainers that required LED
node to be referenced by a phandle to the node instead of indirectly by
the LED label and for timevalue to have a suffix.

While at it generalize the LED node label parsing since the logic is
common for generic LED bind and LED activity/boot.

Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
This commit is contained in:
Christian Marangi 2024-11-10 12:50:26 +01:00 • committed by Tom Rini
parent c2aecfbe2c
commit 69542d0692
1 changed files with 22 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
drivers/led/led-uclass.c
View file

@ -232,16 +232,24 @@ int led_activity_blink(void)
#endif #endif
#endif #endif
static const char *led_get_label(ofnode node)
{
const char *label;
label = ofnode_read_string(node, "label");
if (!label && !ofnode_read_string(node, "compatible"))
label = ofnode_get_name(node);
return label;
}
static int led_post_bind(struct udevice *dev) static int led_post_bind(struct udevice *dev)
{ {
struct led_uc_plat *uc_plat = dev_get_uclass_plat(dev); struct led_uc_plat *uc_plat = dev_get_uclass_plat(dev);
const char *default_state; const char *default_state;
if (!uc_plat->label) if (!uc_plat->label)
uc_plat->label = dev_read_string(dev, "label"); uc_plat->label = led_get_label(dev_ofnode(dev));
if (!uc_plat->label && !dev_read_string(dev, "compatible"))
uc_plat->label = ofnode_get_name(dev_ofnode(dev));
uc_plat->default_state = LEDST_COUNT; uc_plat->default_state = LEDST_COUNT;
@ -300,15 +308,21 @@ static int led_post_probe(struct udevice *dev)
static int led_init(struct uclass *uc) static int led_init(struct uclass *uc)
{ {
struct led_uc_priv *priv = uclass_get_priv(uc); struct led_uc_priv *priv = uclass_get_priv(uc);
ofnode led_node;
int ret;
#ifdef CONFIG_LED_BOOT #ifdef CONFIG_LED_BOOT
priv->boot_led_label = ofnode_options_read_str("boot-led"); ret = ofnode_options_get_by_phandle("boot-led", &led_node);
priv->boot_led_period = ofnode_options_read_int("boot-led-period", 250); if (!ret)
priv->boot_led_label = led_get_label(led_node);
priv->boot_led_period = ofnode_options_read_int("boot-led-period-ms", 250);
#endif #endif
#ifdef CONFIG_LED_ACTIVITY #ifdef CONFIG_LED_ACTIVITY
priv->activity_led_label = ofnode_options_read_str("activity-led"); ret = ofnode_options_get_by_phandle("activity-led", &led_node);
priv->activity_led_period = ofnode_options_read_int("activity-led-period", if (!ret)
priv->activity_led_label = led_get_label(led_node);
priv->activity_led_period = ofnode_options_read_int("activity-led-period-ms",
250); 250);
#endif #endif