Djam/u-boot
1
0
Fork 0
mirror of https://github.com/u-boot/u-boot.git synced 2025-04-25 06:46:00 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

phy: Fix possible NULL pointer deference

Browse source 
It is possible that users of generic_phy_*() APIs may pass a valid
struct phy pointer but phy->dev can be NULL, leading to NULL pointer
deference in phy_dev_ops().

So call generic_phy_valid() to verify that phy and phy->dev are both
valid.

Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
This commit is contained in:
Vignesh Raghavendra 2020-05-20 22:35:41 +05:30 • committed by Tom Rini
parent f4c1f705aa
commit 64b69f8c89
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
drivers/phy/phy-uclass.c
View file

@ -118,7 +118,7 @@ int generic_phy_init(struct phy *phy)
{ {
struct phy_ops const *ops; struct phy_ops const *ops;
if (!phy) if (!generic_phy_valid(phy))
return 0; return 0;
ops = phy_dev_ops(phy->dev); ops = phy_dev_ops(phy->dev);
@ -129,7 +129,7 @@ int generic_phy_reset(struct phy *phy)
{ {
struct phy_ops const *ops; struct phy_ops const *ops;
if (!phy) if (!generic_phy_valid(phy))
return 0; return 0;
ops = phy_dev_ops(phy->dev); ops = phy_dev_ops(phy->dev);
@ -140,7 +140,7 @@ int generic_phy_exit(struct phy *phy)
{ {
struct phy_ops const *ops; struct phy_ops const *ops;
if (!phy) if (!generic_phy_valid(phy))
return 0; return 0;
ops = phy_dev_ops(phy->dev); ops = phy_dev_ops(phy->dev);
@ -151,7 +151,7 @@ int generic_phy_power_on(struct phy *phy)
{ {
struct phy_ops const *ops; struct phy_ops const *ops;
if (!phy) if (!generic_phy_valid(phy))
return 0; return 0;
ops = phy_dev_ops(phy->dev); ops = phy_dev_ops(phy->dev);
@ -162,7 +162,7 @@ int generic_phy_power_off(struct phy *phy)
{ {
struct phy_ops const *ops; struct phy_ops const *ops;
if (!phy) if (!generic_phy_valid(phy))
return 0; return 0;
ops = phy_dev_ops(phy->dev); ops = phy_dev_ops(phy->dev);