Djam/u-boot
1
0
Fork 0
mirror of https://github.com/u-boot/u-boot.git synced 2025-05-08 10:39:08 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

mtd: nand: Fix data interface configuration logic

Browse source 
When changing from one data interface setting to another, one has to
ensure a specific sequence which is described in the ONFI spec.

One of these constraints is that the CE line has go high after a reset
before a command can be sent with the new data interface setting, which
is not guaranteed by the current implementation.

Rework the nand_reset() function and all the call sites to make sure the
CE line is asserted and released when required.

Also make sure to actually apply the new data interface setting on the
first die.

Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Fixes: d8e725dd8311 ("mtd: nand: automate NAND timings selection")
Reviewed-by: Sascha Hauer <s.hauer@pengutronix.de>
Tested-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
[Linux commit: 73f907fd5fa56b0066d199bdd7126bbd04f6cd7b]
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
This commit is contained in:
Boris Brezillon 2017-11-22 02:38:20 +09:00 • committed by Masahiro Yamada
parent 27c4792cd2
commit 3d841b3214
2 changed files with 37 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

2
include/linux/mtd/nand.h
View file

@ -1198,6 +1198,6 @@ int nand_check_erased_ecc_chunk(void *data, int datalen,
int threshold);
/* Reset and initialize a NAND device */
int nand_reset(struct nand_chip *chip);
int nand_reset(struct nand_chip *chip, int chipnr);
#endif /* __LINUX_MTD_NAND_H */