Djam/u-boot
1
0
Fork 0
mirror of https://github.com/u-boot/u-boot.git synced 2025-04-16 09:54:35 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

test: cmd/hash: check return value of ut_check_console_line

Browse source 
ut_check_console_line() does include an assert.
Pass the result to ut_assertok().

Addresses-Coverity-ID:  514958 Error handling issues
Fixes: 7dfafcd65e ("test: unit test for hash command")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
This commit is contained in:
Heinrich Schuchardt 2024-11-16 21:08:22 +01:00 • committed by Tom Rini
parent deb9a07cf1
commit 3d0da87cd4
1 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
test/cmd/hash.c
View file

@ -33,11 +33,13 @@ static int dm_test_cmd_hash_md5(struct unit_test_state *uts)
strstr(uts->actual_str, "md5 for ")); strstr(uts->actual_str, "md5 for "));
ut_assert(strstr(uts->actual_str, ut_assert(strstr(uts->actual_str,
"d41d8cd98f00b204e9800998ecf8427e")); "d41d8cd98f00b204e9800998ecf8427e"));
ut_check_console_line(uts, "d41d8cd98f00b204e9800998ecf8427e"); ut_assertok(ut_check_console_line(uts,
"d41d8cd98f00b204e9800998ecf8427e"));
if (!CONFIG_IS_ENABLED(HASH_VERIFY)) { if (!CONFIG_IS_ENABLED(HASH_VERIFY)) {
ut_assert(run_command("hash -v sha256 $loadaddr 0 foo", 0)); ut_assert(run_command("hash -v sha256 $loadaddr 0 foo", 0));
ut_check_console_line(uts, "hash - compute hash message digest"); ut_assertok(ut_check_console_line(
uts, "hash - compute hash message digest"));
return 0; return 0;
} }
@ -77,12 +79,13 @@ static int dm_test_cmd_hash_sha256(struct unit_test_state *uts)
strstr(uts->actual_str, "sha256 for ")); strstr(uts->actual_str, "sha256 for "));
ut_assert(strstr(uts->actual_str, ut_assert(strstr(uts->actual_str,
"e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855")); "e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855"));
ut_check_console_line(uts, ut_assertok(ut_check_console_line(
"e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855"); uts, "e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855"));
if (!CONFIG_IS_ENABLED(HASH_VERIFY)) { if (!CONFIG_IS_ENABLED(HASH_VERIFY)) {
ut_assert(run_command("hash -v sha256 $loadaddr 0 foo", 0)); ut_assert(run_command("hash -v sha256 $loadaddr 0 foo", 0));
ut_check_console_line(uts, "hash - compute hash message digest"); ut_assertok(ut_check_console_line(
uts, "hash - compute hash message digest"));
return 0; return 0;
} }