Djam/u-boot
1
0
Fork 0
mirror of https://github.com/u-boot/u-boot.git synced 2025-04-19 03:15:00 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

dfu: fix Kconfig dependencies

Browse source 
Fix link errors caused by missing Kconfig dependencies:

1. DFU_OVER_USB compiles common/dfu.c which calls g_dnl_clear_detach()
which is implemented in drivers/usb/gadget/g_dnl.c which needs
USB_GADGET_DOWNLOAD. Test case:

 $ printf "CONFIG_USB_GADGET_DOWNLOAD=n\nCONFIG_USB_FUNCTION_FASTBOOT=n" \
       >>configs/am62px_evm_a53_defconfig
 $ make am62px_evm_a53_defconfig
 $ make CROSS_COMPILE=aarch64-linux-gnu-
 [...]
 common/dfu.c:34:(.text.run_usb_dnl_gadget+0x68): undefined reference to `g_dnl_clear_detach
 [...]

2. With the above fixed, the same build causes:

 common/spl/spl_dfu.c:29:(.text.spl_dfu_cmd+0xb0): undefined reference to `run_usb_dnl_gadget'

This is because SPL_DFU compiles common/spl/spl_dfu.c which calls
run_usb_dnl_gadget() which is implemented in common/dfu.c which needs
DFU_OVER_USB.

Therefore add these dependencies to Kconfig.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Marek Vasut <marex@denx.de>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Link: https://lore.kernel.org/r/20240910102751.3182982-1-jerome.forissier@linaro.org
Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
This commit is contained in:
Jerome Forissier 2024-09-10 12:27:50 +02:00 • committed by Mattijs Korpershoek
parent 5f04493241
commit 2f9c472dd7
2 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/dfu/Kconfig
View file

@ -7,7 +7,7 @@ config DFU
config DFU_OVER_USB config DFU_OVER_USB
bool bool
select HASH select HASH
depends on USB_GADGET depends on USB_GADGET_DOWNLOAD
config DFU_OVER_TFTP config DFU_OVER_TFTP
bool bool

1
drivers/usb/gadget/Kconfig
View file

@ -323,6 +323,7 @@ config SPL_DFU
bool "Support DFU (Device Firmware Upgrade) in SPL" bool "Support DFU (Device Firmware Upgrade) in SPL"
select SPL_HASH select SPL_HASH
select SPL_DFU_NO_RESET select SPL_DFU_NO_RESET
depends on DFU_OVER_USB
depends on SPL_RAM_SUPPORT depends on SPL_RAM_SUPPORT
help help
This feature enables the DFU (Device Firmware Upgrade) in SPL with This feature enables the DFU (Device Firmware Upgrade) in SPL with