Djam/u-boot
1
0
Fork 0
mirror of https://github.com/u-boot/u-boot.git synced 2025-04-20 20:04:46 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

efi_loader: superfluous statement in is_dir()

Browse source 
When is_dir() is called we have already execute set_blk_dev(fh).
So don't call it again.

This fixes CoverityScan CID 184093.

Reported-by: Tom Rini <trini@konsulko.com>
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Signed-off-by: Alexander Graf <agraf@suse.de>
This commit is contained in:
Heinrich Schuchardt 2018-10-02 05:57:32 +02:00 • committed by Alexander Graf
parent 6f566c231d
commit 2c61e0cc5c
1 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
lib/efi_loader/efi_file.c
View file

@ -52,11 +52,18 @@ static int set_blk_dev(struct file_handle *fh)
return fs_set_blk_dev_with_part(fh->fs->desc, fh->fs->part); return fs_set_blk_dev_with_part(fh->fs->desc, fh->fs->part);
} }
/**
* is_dir() - check if file handle points to directory
*
* We assume that set_blk_dev(fh) has been called already.
*
* @fh: file handle
* Return: true if file handle points to a directory
*/
static int is_dir(struct file_handle *fh) static int is_dir(struct file_handle *fh)
{ {
struct fs_dir_stream *dirs; struct fs_dir_stream *dirs;
set_blk_dev(fh);
dirs = fs_opendir(fh->path); dirs = fs_opendir(fh->path);
if (!dirs) if (!dirs)
return 0; return 0;