Djam/u-boot
1
0
Fork 0
mirror of https://github.com/u-boot/u-boot.git synced 2025-04-19 11:24:42 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

rockchip: rk3288-firefly: Drop unused SPL_LED related code

Browse source 
The firefly-rk3288_defconfig build target does not enable the SPL_LED
Kconfig option.

Drop the unused SPL_LED related code and replace it with a default-state
prop to ensure the LED driver enable the LED at U-Boot proper phase.

Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
This commit is contained in:
Jonas Karlman 2024-12-12 22:09:34 +00:00 • committed by Tom Rini
parent e3c11f96b8
commit 1e3e3534a9
4 changed files with 1 additions and 70 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
arch/arm/dts/rk3288-firefly-u-boot.dtsi
View file

@ -6,20 +6,9 @@
#include "rk3288-u-boot.dtsi"
/ {
config {
bootph-all;
u-boot,boot-led = "firefly:green:power";
};
leds {
bootph-all;
work {
bootph-all;
};
power {
bootph-all;
default-state = "on";
};
};
};
@ -56,10 +45,6 @@
bootph-all;
};
&gpio8 {
bootph-all;
};
&pcfg_pull_up_drv_12ma {
bootph-pre-ram;
};

1
arch/arm/mach-rockchip/rk3288/Kconfig
View file

@ -75,7 +75,6 @@ config TARGET_FENNEC_RK3288
config TARGET_FIREFLY_RK3288
bool "Firefly-RK3288"
select BOARD_LATE_INIT
select SPL_BOARD_INIT if SPL
select TPL
help
Firefly is a RK3288-based development board with 2 USB ports,

7
board/firefly/firefly-rk3288/Makefile
View file

@ -1,7 +0,0 @@
#
# (C) Copyright 2015 Google, Inc
#
# SPDX-License-Identifier: GPL-2.0+
#
obj-y += firefly-rk3288.o

46
board/firefly/firefly-rk3288/firefly-rk3288.c
View file

@ -1,46 +0,0 @@
// SPDX-License-Identifier: GPL-2.0+
/*
* (C) Copyright 2015 Google, Inc
*/
#include <hang.h>
#include <led.h>
#include <log.h>
#include <asm/global_data.h>
#include <dm/ofnode.h>
#ifdef CONFIG_XPL_BUILD
static int setup_led(void)
{
#ifdef CONFIG_SPL_LED
struct udevice *dev;
char *led_name;
int ret;
led_name = ofnode_conf_read_str("u-boot,boot-led");
if (!led_name)
return 0;
ret = led_get_by_label(led_name, &dev);
if (ret) {
debug("%s: get=%d\n", __func__, ret);
return ret;
}
ret = led_set_state(dev, LEDST_ON);
if (ret)
return ret;
#endif
return 0;
}
void spl_board_init(void)
{
int ret;
ret = setup_led();
if (ret) {
debug("LED ret=%d\n", ret);
hang();
}
}
#endif