efi_loader: avoid duplicate weak invalidate_icache_all()

If multiple weak implementations of a weak function exist, it is unclear
which one the linker should chose. cmd/cache.c already defines a weak
invalidate_icache_all().

We don't need a call to invalidate_icache_all() on x86.
ARM, RISC-V, and Sandbox provide an implementation.

Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
This commit is contained in:
Heinrich Schuchardt 2024-06-16 19:31:05 +02:00 committed by Tom Rini
parent 15a15e3feb
commit 19d41f495a
2 changed files with 13 additions and 7 deletions

View file

@ -783,7 +783,12 @@ void efi_runtime_relocate(ulong offset, struct efi_mem_desc *map)
lastoff = offset;
#endif
invalidate_icache_all();
/*
* If on x86 a write affects a prefetched instruction,
* the prefetch queue is invalidated.
*/
if (!CONFIG_IS_ENABLED(X86))
invalidate_icache_all();
}
/**