Djam/u-boot
1
0
Fork 0
mirror of https://github.com/u-boot/u-boot.git synced 2025-04-22 04:44:46 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

binman: Switch to 'python-coverage'

Browse source 
The most portable way to get access to coverage is to invoke it as
'python-coverage'.

Cc: Simon Glass <sjg@chromium.org>
Signed-off-by: Tom Rini <trini@konsulko.com>
Signed-off-by: Simon Glass <sjg@chromium.org>
This commit is contained in:
Tom Rini 2018-07-06 10:27:14 -06:00 • committed by Simon Glass
parent 31e60ffa05
commit 16d836cd6f
3 changed files with 7 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
test/run
View file

@ -26,8 +26,7 @@ PYTHONPATH=${DTC_DIR}/pylibfdt DTC=${DTC_DIR}/dtc run_test ./tools/dtoc/dtoc -t
# This needs you to set up Python test coverage tools. # This needs you to set up Python test coverage tools.
# To enable Python test coverage on Debian-type distributions (e.g. Ubuntu): # To enable Python test coverage on Debian-type distributions (e.g. Ubuntu):
# $ sudo apt-get install python-pip python-pytest # $ sudo apt-get install python-pytest python-coverage
# $ sudo pip install coverage
PYTHONPATH=${DTC_DIR}/pylibfdt DTC=${DTC_DIR}/dtc run_test \ PYTHONPATH=${DTC_DIR}/pylibfdt DTC=${DTC_DIR}/dtc run_test \
./tools/binman/binman -T ./tools/binman/binman -T

3
tools/binman/README
View file

@ -583,8 +583,7 @@ implementations target 100% test coverage. Run 'binman -T' to check this.
To enable Python test coverage on Debian-type distributions (e.g. Ubuntu): To enable Python test coverage on Debian-type distributions (e.g. Ubuntu):
$ sudo apt-get install python-pip python-pytest $ sudo apt-get install python-coverage python-pytest
$ sudo pip install coverage
Advanced Features / Technical docs Advanced Features / Technical docs

9
tools/binman/binman.py
View file

@ -81,24 +81,25 @@ def RunTests(debug, args):
def RunTestCoverage(): def RunTestCoverage():
"""Run the tests and check that we get 100% coverage""" """Run the tests and check that we get 100% coverage"""
# This uses the build output from sandbox_spl to get _libfdt.so # This uses the build output from sandbox_spl to get _libfdt.so
cmd = ('PYTHONPATH=$PYTHONPATH:%s/sandbox_spl/tools coverage run ' cmd = ('PYTHONPATH=$PYTHONPATH:%s/sandbox_spl/tools python-coverage run '
'--include "tools/binman/*.py" --omit "*test*,*binman.py" ' '--include "tools/binman/*.py" --omit "*test*,*binman.py" '
'tools/binman/binman.py -t' % options.build_dir) 'tools/binman/binman.py -t' % options.build_dir)
os.system(cmd) os.system(cmd)
stdout = command.Output('coverage', 'report') stdout = command.Output('python-coverage', 'report')
lines = stdout.splitlines() lines = stdout.splitlines()
test_set= set([os.path.basename(line.split()[0]) test_set= set([os.path.basename(line.split()[0])
for line in lines if '/etype/' in line]) for line in lines if '/etype/' in line])
glob_list = glob.glob(os.path.join(our_path, 'etype/*.py')) glob_list = glob.glob(os.path.join(our_path, 'etype/*.py'))
all_set = set([os.path.basename(item) for item in glob_list]) all_set = set([os.path.splitext(os.path.basename(item))[0]
for item in glob_list if '_testing' not in item])
missing_list = all_set missing_list = all_set
missing_list.difference_update(test_set) missing_list.difference_update(test_set)
missing_list.remove('_testing.py')
coverage = lines[-1].split(' ')[-1] coverage = lines[-1].split(' ')[-1]
ok = True ok = True
if missing_list: if missing_list:
print 'Missing tests for %s' % (', '.join(missing_list)) print 'Missing tests for %s' % (', '.join(missing_list))
print stdout
ok = False ok = False
if coverage != '100%': if coverage != '100%':
print stdout print stdout