Djam/u-boot
1
0
Fork 0
mirror of https://github.com/u-boot/u-boot.git synced 2025-04-21 20:34:38 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

arm64: zynqmp: Fix command error values properly

Browse source 
Process errors from command via cmd_process_error() as is done on Versal.
When internal function returns different number then CMD_RET_SUCCESS(0),
CMD_RET_FAILURE(1) or CMD_RET_USAGE(-1) shell react on these errors by
throwing an error like
"exit not allowed from main input shell." that's why use
cmd_process_error() to make sure that error code is all the time correct.

Signed-off-by: Michal Simek <michal.simek@amd.com>
Link: https://lore.kernel.org/r/d511935ba10daf95c70996fae6e6ffc374efffa0.1685618464.git.michal.simek@amd.com
This commit is contained in:
Michal Simek 2023-06-01 13:21:07 +02:00
parent 322c0da86a
commit 04cc6f0a53
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
board/xilinx/zynqmp/cmds.c
View file

@ -394,17 +394,17 @@ static int do_zynqmp(struct cmd_tbl *cmdtp, int flag, int argc,
char *const argv[]) char *const argv[])
{ {
struct cmd_tbl *c; struct cmd_tbl *c;
int ret = CMD_RET_USAGE;
if (argc < 2) if (argc < 2)
return CMD_RET_USAGE; return CMD_RET_USAGE;
c = find_cmd_tbl(argv[1], &cmd_zynqmp_sub[0], c = find_cmd_tbl(argv[1], &cmd_zynqmp_sub[0],
ARRAY_SIZE(cmd_zynqmp_sub)); ARRAY_SIZE(cmd_zynqmp_sub));
if (c) if (c)
return c->cmd(c, flag, argc, argv); ret = c->cmd(c, flag, argc, argv);
else
return CMD_RET_USAGE; return cmd_process_error(c, ret);
} }
/***************************************************/ /***************************************************/