mirror of
https://github.com/u-boot/u-boot.git
synced 2025-04-16 18:04:48 +00:00
env: sf: report malloc error to caller
In the non-redundant code for env_sf_save(), a failure to malloc() the temporary buffer produces the following output: Saving Environment to SPIFlash... OK This is misleading as the flash has neither been erased nor written. Fix it to return an error to the caller, so the output will be: Saving Environment to SPIFlash... Failed (-12) Note that there is another copy of env_sf_save() in the same file, for handling redundant environment, and it already has the same logic. Signed-off-by: Ralph Siemsen <ralph.siemsen@linaro.org>
This commit is contained in:
parent
ca6d60df2f
commit
04add62e8c
1 changed files with 3 additions and 1 deletions
4
env/sf.c
vendored
4
env/sf.c
vendored
|
@ -210,8 +210,10 @@ static int env_sf_save(void)
|
|||
saved_size = sect_size - CONFIG_ENV_SIZE;
|
||||
saved_offset = CONFIG_ENV_OFFSET + CONFIG_ENV_SIZE;
|
||||
saved_buffer = malloc(saved_size);
|
||||
if (!saved_buffer)
|
||||
if (!saved_buffer) {
|
||||
ret = -ENOMEM;
|
||||
goto done;
|
||||
}
|
||||
|
||||
ret = spi_flash_read(env_flash, saved_offset,
|
||||
saved_size, saved_buffer);
|
||||
|
|
Loading…
Add table
Reference in a new issue