samba/0001-s3-libads-Fix-mem-leak-in-ads_create_machine_acct.patch

32 lines
994 B
Diff

From cbd80827c5c6ec871b9d8bf2d927a2f723a26922 Mon Sep 17 00:00:00 2001
From: Jones Syue <jonessyue@qnap.com>
Date: Fri, 1 Nov 2019 15:50:29 +0800
Subject: [PATCH] s3:libads: Fix mem leak in ads_create_machine_acct
Use 'goto done' instead of 'return' to fix machine_escaped leak.
Signed-off-by: Jones Syue <jonessyue@qnap.com>
---
source3/libads/ldap.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
mode change 100644 => 100755 source3/libads/ldap.c
diff --git a/source3/libads/ldap.c b/source3/libads/ldap.c
old mode 100644
new mode 100755
index 90d402a..a630c5a
--- a/source3/libads/ldap.c
+++ b/source3/libads/ldap.c
@@ -2370,7 +2370,8 @@ ADS_STATUS ads_create_machine_acct(ADS_STRUCT *ads,
/* Make sure to NULL terminate the array */
spn_array = talloc_realloc(ctx, spn_array, const char *, num_spns + 1);
if (spn_array == NULL) {
- return ADS_ERROR_LDAP(LDAP_NO_MEMORY);
+ ret = ADS_ERROR(LDAP_NO_MEMORY);
+ goto done;
}
spn_array[num_spns] = NULL;
--
2.1.4