mirror of
https://abf.rosa.ru/djam/kernel-6.6.git
synced 2025-02-25 20:02:47 +00:00
36 lines
1.3 KiB
Diff
36 lines
1.3 KiB
Diff
From 2eee05020a0e7ee7c04422cbacdb07859e45dce6 Mon Sep 17 00:00:00 2001
|
|
From: Johan Hovold <johan@kernel.org>
|
|
Date: Fri, 13 Jan 2017 13:21:08 +0100
|
|
Subject: USB: serial: opticon: fix CTS retrieval at open
|
|
|
|
From: Johan Hovold <johan@kernel.org>
|
|
|
|
commit 2eee05020a0e7ee7c04422cbacdb07859e45dce6 upstream.
|
|
|
|
The opticon driver used a control request at open to trigger a CTS
|
|
status notification to be sent over the bulk-in pipe. When the driver
|
|
was converted to using the generic read implementation, an inverted test
|
|
prevented this request from being sent, something which could lead to
|
|
TIOCMGET reporting an incorrect CTS state.
|
|
|
|
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
|
|
Fixes: 7a6ee2b02751 ("USB: opticon: switch to generic read implementation")
|
|
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
Signed-off-by: Johan Hovold <johan@kernel.org>
|
|
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
|
|
---
|
|
drivers/usb/serial/opticon.c | 2 +-
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
--- a/drivers/usb/serial/opticon.c
|
|
+++ b/drivers/usb/serial/opticon.c
|
|
@@ -142,7 +142,7 @@ static int opticon_open(struct tty_struc
|
|
usb_clear_halt(port->serial->dev, port->read_urb->pipe);
|
|
|
|
res = usb_serial_generic_open(tty, port);
|
|
- if (!res)
|
|
+ if (res)
|
|
return res;
|
|
|
|
/* Request CTS line state, sometimes during opening the current
|