From f47f95e40d7f45d0984c9f923549a137f62d0816 Mon Sep 17 00:00:00 2001 From: Mikhail Novosyolov Date: Thu, 6 May 2021 00:49:26 +0300 Subject: [PATCH] Remove patches of codecs I am fed up in updating those patches to newer releases of Chromium, they seem to be not really useful and, if I remember correctly, they made some regressions. Dropping them. --- chromium-40-sorenson-spark.patch | 381 ------------------------- chromium-40-wmvflvmpg.patch | 90 ------ chromium-55-extra-media.patch | 464 ------------------------------- chromium-browser-stable.spec | 9 - 4 files changed, 944 deletions(-) delete mode 100644 chromium-40-sorenson-spark.patch delete mode 100644 chromium-40-wmvflvmpg.patch delete mode 100644 chromium-55-extra-media.patch diff --git a/chromium-40-sorenson-spark.patch b/chromium-40-sorenson-spark.patch deleted file mode 100644 index 789d6ff..0000000 --- a/chromium-40-sorenson-spark.patch +++ /dev/null @@ -1,381 +0,0 @@ -diff -up chromium-62.0.3192.0/media/base/mime_util_internal.h.wmvflvmpg chromium-62.0.3192.0/media/base/mime_util_internal.h ---- chromium-62.0.3192.0/media/base/mime_util_internal.h.wmvflvmpg 2017-08-30 15:52:00.602204610 +0200 -+++ chromium-62.0.3192.0/media/base/mime_util_internal.h 2017-08-30 15:52:00.616204356 +0200 -@@ -48,7 +48,20 @@ class MEDIA_EXPORT MimeUtil { - MP2, - MPEG4_SP, - MPEG4_ASP, -- LAST_CODEC = MPEG4_ASP -+ MSMPEG4v1, -+ MSMPEG4v2, -+ MSMPEG4v3, -+ WMV7, -+ WMV8, -+ WMV9, -+ VC1, -+ WMA1, -+ WMA2, -+ VP6, -+ MPEG1, -+ MPEG2, -+ FLV1, -+ LAST_CODEC = FLV1 - }; - - // Platform configuration structure. Controls which codecs are supported at -diff -up chromium-51.0.2687.0/media/ffmpeg/ffmpeg_common.cc.flv1 chromium-51.0.2687.0/media/ffmpeg/ffmpeg_common.cc ---- chromium-51.0.2687.0/media/ffmpeg/ffmpeg_common.cc.flv1 2016-03-23 18:22:20.227596097 +0100 -+++ chromium-51.0.2687.0/media/ffmpeg/ffmpeg_common.cc 2016-03-23 18:22:20.245595771 +0100 -@@ -120,6 +120,10 @@ AudioCodec CodecIDToAudioCodec(AVCodecID - return kCodecMP2; - case AV_CODEC_ID_DTS: - return kCodecDTS; -+ case AV_CODEC_ID_WMAV1: -+ return kCodecWMA1; -+ case AV_CODEC_ID_WMAV2: -+ return kCodecWMA2; - default: - DVLOG(1) << "Unknown audio CodecID: " << codec_id; - } -@@ -179,6 +183,10 @@ AVCodecID AudioCodecToCodecID(AudioCodec - return AV_CODEC_ID_MP2; - case kCodecDTS: - return AV_CODEC_ID_DTS; -+ case kCodecWMA1: -+ return AV_CODEC_ID_WMAV1; -+ case kCodecWMA2: -+ return AV_CODEC_ID_WMAV2; - default: - DVLOG(1) << "Unknown AudioCodec: " << audio_codec; - } -@@ -197,6 +197,28 @@ - return kCodecVP9; - case AV_CODEC_ID_AV1: - return kCodecAV1; -+ case AV_CODEC_ID_MSMPEG4V1: -+ return kCodecMSMPEG4V1; -+ case AV_CODEC_ID_MSMPEG4V2: -+ return kCodecMSMPEG4V2; -+ case AV_CODEC_ID_MSMPEG4V3: -+ return kCodecMSMPEG4V3; -+ case AV_CODEC_ID_WMV1: -+ return kCodecWMV7; -+ case AV_CODEC_ID_WMV2: -+ return kCodecWMV8; -+ case AV_CODEC_ID_WMV3: -+ return kCodecWMV9; -+ case AV_CODEC_ID_VC1: -+ return kCodecVC1; -+ case AV_CODEC_ID_VP6: -+ return kCodecVP6; -+ case AV_CODEC_ID_MPEG1VIDEO: -+ return kCodecMPEG1; -+ case AV_CODEC_ID_MPEG2VIDEO: -+ return kCodecMPEG2; -+ case AV_CODEC_ID_FLV1: -+ return kCodecSorensonSpark; - default: - DVLOG(1) << "Unknown video CodecID: " << codec_id; - } ---- chromium-56.0.2924.10/media/remoting/proto_enum_utils.cc.bak.2 2016-12-01 23:42:15.717317808 +0100 -+++ chromium-56.0.2924.10/media/remoting/proto_enum_utils.cc 2016-12-01 23:44:59.695754038 +0100 -@@ -36,6 +36,8 @@ base::Optional ToMediaAudioC - CASE_RETURN_OTHER(kCodecMpegHAudio); - CASE_RETURN_OTHER(kCodecMP2); - CASE_RETURN_OTHER(kCodecDTS); -+ CASE_RETURN_OTHER(kCodecWMA1); -+ CASE_RETURN_OTHER(kCodecWMA2); - } - return base::nullopt; // Not a 'default' to ensure compile-time checks. - } -@@ -65,6 +67,8 @@ base::Optional ToMediaVideoC - CASE_RETURN_OTHER(kCodecHEVC); - CASE_RETURN_OTHER(kCodecDolbyVision); - CASE_RETURN_OTHER(kCodecAV1); -+ CASE_RETURN_OTHER(kCodecMSMPEG4V1); -+ CASE_RETURN_OTHER(kCodecMSMPEG4V2); -+ CASE_RETURN_OTHER(kCodecMSMPEG4V3); -+ CASE_RETURN_OTHER(kCodecWMV7); -+ CASE_RETURN_OTHER(kCodecWMV8); -+ CASE_RETURN_OTHER(kCodecWMV9); -+ CASE_RETURN_OTHER(kCodecVP6); -+ CASE_RETURN_OTHER(kCodecMPEG1); -+ CASE_RETURN_OTHER(kCodecSorensonSpark); - } - return base::nullopt; // Not a 'default' to ensure compile-time checks. - } -@@ -231,6 +244,15 @@ base::Optionalchannels); - - int sample_rate = codec_context->sample_rate; -- switch (codec) { -- // For AC3/EAC3 we enable only demuxing, but not decoding, so FFmpeg does -- // not fill |sample_fmt|. -- case kCodecAC3: -- case kCodecEAC3: --#if BUILDFLAG(ENABLE_PLATFORM_AC3_EAC3_AUDIO) -- // The spec for AC3/EAC3 audio is ETSI TS 102 366. According to sections -- // F.3.1 and F.5.1 in that spec the sample_format for AC3/EAC3 must be 16. -- sample_format = kSampleFormatS16; --#else -- NOTREACHED(); --#endif -- break; --#if BUILDFLAG(ENABLE_PLATFORM_MPEG_H_AUDIO) -- case kCodecMpegHAudio: -- channel_layout = CHANNEL_LAYOUT_BITSTREAM; -- sample_format = kSampleFormatMpegHAudio; -- break; --#endif -- -- default: -- break; -- } -- - base::TimeDelta seek_preroll; - if (codec_context->seek_preroll > 0) { - seek_preroll = base::TimeDelta::FromMicroseconds( -@@ -399,17 +387,6 @@ bool AVCodecContextToAudioDecoderConfig( - if (channel_layout == CHANNEL_LAYOUT_DISCRETE) - config->SetChannelsForDiscrete(codec_context->channels); - --#if BUILDFLAG(ENABLE_PLATFORM_AC3_EAC3_AUDIO) -- // These are bitstream formats unknown to ffmpeg, so they don't have -- // a known sample format size. -- if (codec == kCodecAC3 || codec == kCodecEAC3) -- return true; --#endif --#if BUILDFLAG(ENABLE_PLATFORM_MPEG_H_AUDIO) -- if (codec == kCodecMpegHAudio) -- return true; --#endif -- - #if BUILDFLAG(USE_PROPRIETARY_CODECS) - // TODO(dalecurtis): Just use the profile from the codec context if ffmpeg - // ever starts supporting xHE-AAC. -diff -up chromium-62.0.3192.0/media/filters/ffmpeg_video_decoder.cc.extra-media chromium-62.0.3192.0/media/filters/ffmpeg_video_decoder.cc ---- chromium-62.0.3192.0/media/filters/ffmpeg_video_decoder.cc.extra-media 2017-08-22 21:04:45.000000000 +0200 -+++ chromium-62.0.3192.0/media/filters/ffmpeg_video_decoder.cc 2017-08-30 15:39:09.736186059 +0200 -@@ -38,7 +38,6 @@ - case kUnknownVideoCodec: - case kCodecVC1: - case kCodecMPEG2: -- case kCodecHEVC: - case kCodecVP9: - case kCodecAV1: - case kCodecDolbyVision: -@@ -52,6 +51,7 @@ - - case kCodecH264: - case kCodecVP8: -+ case kCodecHEVC: - // Normalize to three threads for 1080p content, then scale linearly - // with number of pixels. - // Examples: -diff -up chromium-62.0.3192.0/media/remoting/proto_enum_utils.cc.extra-media chromium-62.0.3192.0/media/remoting/proto_enum_utils.cc ---- chromium-62.0.3192.0/media/remoting/proto_enum_utils.cc.extra-media 2017-08-22 21:04:45.000000000 +0200 -+++ chromium-62.0.3192.0/media/remoting/proto_enum_utils.cc 2017-08-30 15:39:09.736186059 +0200 -@@ -34,6 +34,8 @@ base::Optional ToMediaAudioC - CASE_RETURN_OTHER(kCodecALAC); - CASE_RETURN_OTHER(kCodecAC3); - CASE_RETURN_OTHER(kCodecMpegHAudio); -+ CASE_RETURN_OTHER(kCodecMP2); -+ CASE_RETURN_OTHER(kCodecDTS); - } - return base::nullopt; // Not a 'default' to ensure compile-time checks. - } -@@ -61,6 +63,8 @@ base::OptionalHasSwitch( - switches::kEnableClearHevcForTesting)) { -@@ -69,7 +68,6 @@ bool IsHevcProfileSupported(VideoCodecPr - } - return false; - } --#endif // ENABLE_PLATFORM_HEVC && USE_CHROMEOS_PROTECTED_MEDIA - - } // namespace - -@@ -205,14 +203,18 @@ bool IsAudioCodecProprietary(AudioCodec - case kCodecAAC: - case kCodecAC3: - case kCodecEAC3: -+ case kCodecDTS: - case kCodecAMR_NB: - case kCodecAMR_WB: - case kCodecGSM_MS: - case kCodecALAC: - case kCodecMpegHAudio: -+ case kCodecWMA1: -+ case kCodecWMA2: - return true; - - case kCodecFLAC: -+ case kCodecMP2: - case kCodecMP3: - case kCodecOpus: - case kCodecVorbis: -@@ -250,6 +252,7 @@ bool IsDefaultSupportedAudioType(const A - #endif - - case kCodecFLAC: -+ case kCodecMP2: - case kCodecMP3: - case kCodecOpus: - case kCodecPCM: -@@ -258,6 +261,12 @@ bool IsDefaultSupportedAudioType(const A - case kCodecPCM_S24BE: - case kCodecPCM_ALAW: - case kCodecVorbis: -+ case kCodecEAC3: -+ case kCodecALAC: -+ case kCodecAC3: -+ case kCodecDTS: -+ case kCodecWMA1: -+ case kCodecWMA2: - return true; - - case kCodecAMR_NB: -@@ -269,9 +278,6 @@ bool IsDefaultSupportedAudioType(const A - return false; - #endif - -- case kCodecEAC3: -- case kCodecALAC: -- case kCodecAC3: - case kCodecMpegHAudio: - case kUnknownAudioCodec: - return false; -@@ -289,6 +295,15 @@ bool IsVideoCodecProprietary(VideoCodec - case kCodecMPEG4: - case kCodecHEVC: - case kCodecDolbyVision: -+ case kCodecMSMPEG4V1: -+ case kCodecMSMPEG4V2: -+ case kCodecMSMPEG4V3: -+ case kCodecWMV7: -+ case kCodecWMV8: -+ case kCodecWMV9: -+ case kCodecVP6: -+ case kCodecMPEG1: -+ case kCodecSorensonSpark: - return true; - case kUnknownVideoCodec: - case kCodecTheora: -@@ -336,27 +351,26 @@ bool IsDefaultSupportedVideoType(const V - case kCodecH264: - case kCodecVP8: - case kCodecTheora: -+ case kCodecVC1: -+ case kCodecMPEG2: -+ case kCodecMPEG4: -+ case kCodecMSMPEG4V1: -+ case kCodecMSMPEG4V2: -+ case kCodecMSMPEG4V3: -+ case kCodecWMV7: -+ case kCodecWMV8: -+ case kCodecWMV9: -+ case kCodecVP6: -+ case kCodecMPEG1: -+ case kCodecSorensonSpark: - return true; - - case kCodecHEVC: --#if BUILDFLAG(ENABLE_PLATFORM_HEVC) && BUILDFLAG(USE_CHROMEOS_PROTECTED_MEDIA) - return IsColorSpaceSupported(type.color_space) && - IsHevcProfileSupported(type.profile); --#else -- return false; --#endif - case kUnknownVideoCodec: -- case kCodecVC1: -- case kCodecMPEG2: - case kCodecDolbyVision: - return false; -- -- case kCodecMPEG4: --#if BUILDFLAG(IS_CHROMEOS_ASH) -- return true; --#else -- return false; --#endif - } - - NOTREACHED(); ---- chromium-89.0.4389.47/chrome/renderer/media/chrome_key_systems.cc.extra-media 2021-02-11 00:03:54.000000000 +0100 -+++ chromium-89.0.4389.47/chrome/renderer/media/chrome_key_systems.cc 2021-02-17 00:23:43.715337084 +0100 -@@ -182,11 +182,8 @@ static SupportedCodecs GetSupportedCodec - #endif // BUILDFLAG(USE_PROPRIETARY_CODECS) - #if BUILDFLAG(ENABLE_PLATFORM_HEVC) - case media::VideoCodec::kCodecHEVC: -- if (is_secure && base::FeatureList::IsEnabled( -- chromeos::features::kCdmFactoryDaemon)) { - supported_codecs |= media::EME_CODEC_HEVC_PROFILE_MAIN; - supported_codecs |= media::EME_CODEC_HEVC_PROFILE_MAIN10; -- } - break; - #endif // BUILDFLAG(ENABLE_PLATFORM_HEVC) - default: diff --git a/chromium-browser-stable.spec b/chromium-browser-stable.spec index bba3afb..9372832 100644 --- a/chromium-browser-stable.spec +++ b/chromium-browser-stable.spec @@ -104,12 +104,6 @@ Source1102: https://github.com/deemru/msspi/archive/%{msspi_ver}.tar.gz?/msspi-% Patch1: chromium-79.0.3945.88-deleted-chromium-gost-info.patch Patch4: chromium-30.0.1599.66-master-prefs-path.patch -# (cjw) Recognize mimetypes for matroska (.mkv) and AVI (.avi) formats (video/x-matroska and audio/x-matroska, video/x-msvideo) + handle A52 "AC3" and DTS compressed audio. -Patch6: chromium-55-extra-media.patch -# (cjw) [1/2] Recognize mimetypes for WMV (.wmv), FLV (.flv) and MPEG (.mpg) videos -Patch7: chromium-40-wmvflvmpg.patch -# (cjw) [2/2] Handle more video codecs. -Patch8: chromium-40-sorenson-spark.patch Patch22: chromium-54-proprietary-codecs-assert.patch %if 0%{jsoncpp} @@ -350,9 +344,6 @@ cp -f %{_gostsourcedir}/src/msspi/third_party/cprocsp/include/* third_party/bori %endif %patch4 -p1 -b .prefs -%patch6 -p1 -%patch7 -p1 -%patch8 -p1 %patch22 -p1 %if 0%{jsoncpp} %patch28 -p1