Djam/arm-trusted-firmware
1
0
Fork 0
mirror of https://github.com/ARM-software/arm-trusted-firmware.git synced 2025-04-08 05:43:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
arm-trusted-firmware/lib/extensions/amu/aarch32/amu.c
Boyan Karatotev 83ec7e452c perf(amu): greatly simplify AMU context management 
The current code is incredibly resilient to updates to the spec and
has worked quite well so far. However, recent implementations expose a
weakness in that this is rather slow. A large part of it is written in
assembly, making it opaque to the compiler for optimisations. The
future proofness requires reading registers that are effectively
`volatile`, making it even harder for the compiler, as well as adding
lots of implicit barriers, making it hard for the microarchitecutre to
optimise as well.

We can make a few assumptions, checked by a few well placed asserts, and
remove a lot of this burden. For a start, at the moment there are 4
group 0 counters with static assignments. Contexting them is a trivial
affair that doesn't need a loop. Similarly, there can only be up to 16
group 1 counters. Contexting them is a bit harder, but we can do with a
single branch with a falling through switch. If/when both of these
change, we have a pair of asserts and the feature detection mechanism to
guard us against pretending that we support something we don't.

We can drop contexting of the offset registers. They are fully
accessible by EL2 and as such are its responsibility to preserve on
powerdown.

Another small thing we can do, is pass the core_pos into the hook.
The caller already knows which core we're running on, we don't need to
call this non-trivial function again.

Finally, knowing this, we don't really need the auxiliary AMUs to be
described by the device tree. Linux doesn't care at the moment, and any
information we need for EL3 can be neatly placed in a simple array.

All of this, combined with lifting the actual saving out of assembly,
reduces the instructions to save the context from 180 to 40, including a
lot fewer branches. The code is also much shorter and easier to read.

Also propagate to aarch32 so that the two don't diverge too much.

Change-Id: Ib62e6e9ba5be7fb9fb8965c8eee148d5598a5361
Signed-off-by: Boyan Karatotev <boyan.karatotev@arm.com>
2025-02-25 08:50:46 +00:00

244 lines
6.4 KiB
C
Raw Blame History

/*
* Copyright (c) 2017-2025, Arm Limited and Contributors. All rights reserved.
*
* SPDX-License-Identifier: BSD-3-Clause
*/
#include <assert.h>
#include <cdefs.h>
#include <stdbool.h>
#include <arch.h>
#include <arch_features.h>
#include <arch_helpers.h>
#include <common/debug.h>
#include <lib/el3_runtime/pubsub_events.h>
#include <lib/extensions/amu.h>
#include <plat/common/platform.h>
amu_regs_t amu_ctx[PLATFORM_CORE_COUNT];
static inline __unused uint32_t read_amcgcr_cg1nc(void)
{
return (read_amcgcr() >> AMCGCR_CG1NC_SHIFT) &
AMCGCR_CG1NC_MASK;
}
/*
* Enable counters. This function is meant to be invoked by the context
* management library before exiting from EL3.
*/
void amu_enable(bool el2_unused)
{
if (el2_unused) {
/*
* HCPTR.TAM: Set to zero so any accesses to the Activity
* Monitor registers do not trap to EL2.
*/
write_hcptr(read_hcptr() & ~TAM_BIT);
}
/* Architecture is currently pinned to 4 */
assert((read_amcgcr() & AMCGCR_CG0NC_MASK) == CTX_AMU_GRP0_ALL);
/* Enable all architected counters by default */
write_amcntenset0(AMCNTENSET0_Pn_MASK);
if (is_feat_amu_aux_supported()) {
unsigned int core_pos = plat_my_core_pos();
/* Something went wrong if we're trying to write higher bits */
assert((get_amu_aux_enables(core_pos) & ~AMCNTENSET1_Pn_MASK) == 0);
write_amcntenset1(get_amu_aux_enables(core_pos));
}
/* Bail out if FEAT_AMUv1p1 features are not present. */
if (!is_feat_amuv1p1_supported()) {
return;
}
#if AMU_RESTRICT_COUNTERS
/*
* FEAT_AMUv1p1 adds a register field to restrict access to group 1
* counters at all but the highest implemented EL. This is controlled
* with the AMU_RESTRICT_COUNTERS compile time flag, when set, system
* register reads at lower ELs return zero. Reads from the memory
* mapped view are unaffected.
*/
VERBOSE("AMU group 1 counter access restricted.\n");
write_amcr(read_amcr() | 1U);
#else
write_amcr(0);
#endif
}
static void *amu_context_save(const void *arg)
{
if (!is_feat_amu_supported()) {
return (void *)0;
}
unsigned int core_pos = *(unsigned int *)arg;
amu_regs_t *ctx = &amu_ctx[core_pos];
/* Disable all counters so we can write to them safely later */
write_amcntenclr0(AMCNTENCLR0_Pn_MASK);
if (is_feat_amu_aux_supported()) {
write_amcntenclr1(get_amu_aux_enables(core_pos));
}
isb(); /* Ensure counters have been stopped */
write_amu_grp0_ctx_reg(ctx, 0, read64_amevcntr00());
write_amu_grp0_ctx_reg(ctx, 1, read64_amevcntr01());
write_amu_grp0_ctx_reg(ctx, 2, read64_amevcntr02());
write_amu_grp0_ctx_reg(ctx, 3, read64_amevcntr03());
if (is_feat_amu_aux_supported()) {
uint8_t num_counters = read_amcgcr_cg1nc();
switch (num_counters) {
case 0x10:
write_amu_grp1_ctx_reg(ctx, 0xf, read64_amevcntr1f());
__fallthrough;
case 0x0f:
write_amu_grp1_ctx_reg(ctx, 0xe, read64_amevcntr1e());
__fallthrough;
case 0x0e:
write_amu_grp1_ctx_reg(ctx, 0xd, read64_amevcntr1d());
__fallthrough;
case 0x0d:
write_amu_grp1_ctx_reg(ctx, 0xc, read64_amevcntr1c());
__fallthrough;
case 0x0c:
write_amu_grp1_ctx_reg(ctx, 0xb, read64_amevcntr1b());
__fallthrough;
case 0x0b:
write_amu_grp1_ctx_reg(ctx, 0xa, read64_amevcntr1a());
__fallthrough;
case 0x0a:
write_amu_grp1_ctx_reg(ctx, 0x9, read64_amevcntr19());
__fallthrough;
case 0x09:
write_amu_grp1_ctx_reg(ctx, 0x8, read64_amevcntr18());
__fallthrough;
case 0x08:
write_amu_grp1_ctx_reg(ctx, 0x7, read64_amevcntr17());
__fallthrough;
case 0x07:
write_amu_grp1_ctx_reg(ctx, 0x6, read64_amevcntr16());
__fallthrough;
case 0x06:
write_amu_grp1_ctx_reg(ctx, 0x5, read64_amevcntr15());
__fallthrough;
case 0x05:
write_amu_grp1_ctx_reg(ctx, 0x4, read64_amevcntr14());
__fallthrough;
case 0x04:
write_amu_grp1_ctx_reg(ctx, 0x3, read64_amevcntr13());
__fallthrough;
case 0x03:
write_amu_grp1_ctx_reg(ctx, 0x2, read64_amevcntr12());
__fallthrough;
case 0x02:
write_amu_grp1_ctx_reg(ctx, 0x1, read64_amevcntr11());
__fallthrough;
case 0x01:
write_amu_grp1_ctx_reg(ctx, 0x0, read64_amevcntr10());
__fallthrough;
case 0x00:
break;
default:
assert(0); /* something is wrong */
}
}
return (void *)0;
}
static void *amu_context_restore(const void *arg)
{
if (!is_feat_amu_supported()) {
return (void *)0;
}
unsigned int core_pos = *(unsigned int *)arg;
amu_regs_t *ctx = &amu_ctx[core_pos];
write64_amevcntr00(read_amu_grp0_ctx_reg(ctx, 0));
write64_amevcntr01(read_amu_grp0_ctx_reg(ctx, 1));
write64_amevcntr02(read_amu_grp0_ctx_reg(ctx, 2));
write64_amevcntr03(read_amu_grp0_ctx_reg(ctx, 3));
if (is_feat_amu_aux_supported()) {
uint8_t num_counters = read_amcgcr_cg1nc();
switch (num_counters) {
case 0x10:
write64_amevcntr1f(read_amu_grp1_ctx_reg(ctx, 0xf));
__fallthrough;
case 0x0f:
write64_amevcntr1e(read_amu_grp1_ctx_reg(ctx, 0xe));
__fallthrough;
case 0x0e:
write64_amevcntr1d(read_amu_grp1_ctx_reg(ctx, 0xd));
__fallthrough;
case 0x0d:
write64_amevcntr1c(read_amu_grp1_ctx_reg(ctx, 0xc));
__fallthrough;
case 0x0c:
write64_amevcntr1b(read_amu_grp1_ctx_reg(ctx, 0xb));
__fallthrough;
case 0x0b:
write64_amevcntr1a(read_amu_grp1_ctx_reg(ctx, 0xa));
__fallthrough;
case 0x0a:
write64_amevcntr19(read_amu_grp1_ctx_reg(ctx, 0x9));
__fallthrough;
case 0x09:
write64_amevcntr18(read_amu_grp1_ctx_reg(ctx, 0x8));
__fallthrough;
case 0x08:
write64_amevcntr17(read_amu_grp1_ctx_reg(ctx, 0x7));
__fallthrough;
case 0x07:
write64_amevcntr16(read_amu_grp1_ctx_reg(ctx, 0x6));
__fallthrough;
case 0x06:
write64_amevcntr15(read_amu_grp1_ctx_reg(ctx, 0x5));
__fallthrough;
case 0x05:
write64_amevcntr14(read_amu_grp1_ctx_reg(ctx, 0x4));
__fallthrough;
case 0x04:
write64_amevcntr13(read_amu_grp1_ctx_reg(ctx, 0x3));
__fallthrough;
case 0x03:
write64_amevcntr12(read_amu_grp1_ctx_reg(ctx, 0x2));
__fallthrough;
case 0x02:
write64_amevcntr11(read_amu_grp1_ctx_reg(ctx, 0x1));
__fallthrough;
case 0x01:
write64_amevcntr10(read_amu_grp1_ctx_reg(ctx, 0x0));
__fallthrough;
case 0x00:
break;
default:
assert(0); /* something is wrong */
}
}
/* now enable them again */
write_amcntenset0(AMCNTENSET0_Pn_MASK);
if (is_feat_amu_aux_supported()) {
write_amcntenset1(get_amu_aux_enables(core_pos));
}
isb();
return (void *)0;
}
SUBSCRIBE_TO_EVENT(psci_suspend_pwrdown_start, amu_context_save);
SUBSCRIBE_TO_EVENT(psci_suspend_pwrdown_finish, amu_context_restore);
Reference in a new issue View git blame Copy permalink