mirror of
https://github.com/ARM-software/arm-trusted-firmware.git
synced 2025-04-16 09:34:18 +00:00

The get_bl_mem_params_node() function could return NULL. Add asserts to check the return value is not NULL. This corrects coverity issues: pager_mem_params = get_bl_mem_params_node(BL32_EXTRA1_IMAGE_ID); >>> CID 378360: (NULL_RETURNS) >>> Dereferencing "pager_mem_params", which is known to be "NULL". paged_mem_params = get_bl_mem_params_node(BL32_EXTRA2_IMAGE_ID); >>> CID 378360: (NULL_RETURNS) >>> Dereferencing "paged_mem_params", which is known to be "NULL". tos_fw_mem_params = get_bl_mem_params_node(TOS_FW_CONFIG_ID); >>> CID 378360: (NULL_RETURNS) >>> Dereferencing "tos_fw_mem_params", which is known to be "NULL". Do the same for other occurrences of get_bl_mem_params_node() return not checked, in the functions plat_get_bl_image_load_info() and bl2_plat_handle_pre_image_load(). Signed-off-by: Yann Gautier <yann.gautier@st.com> Change-Id: I79165b1628fcee3da330f2db4ee5e1dafcb1b21f
50 lines
1.6 KiB
C
50 lines
1.6 KiB
C
/*
|
|
* Copyright (c) 2016-2022, ARM Limited and Contributors. All rights reserved.
|
|
*
|
|
* SPDX-License-Identifier: BSD-3-Clause
|
|
*/
|
|
|
|
#include <common/desc_image_load.h>
|
|
#include <plat/common/platform.h>
|
|
|
|
#include <platform_def.h>
|
|
|
|
/*******************************************************************************
|
|
* This function flushes the data structures so that they are visible
|
|
* in memory for the next BL image.
|
|
******************************************************************************/
|
|
void plat_flush_next_bl_params(void)
|
|
{
|
|
flush_bl_params_desc();
|
|
}
|
|
|
|
/*******************************************************************************
|
|
* This function returns the list of loadable images.
|
|
******************************************************************************/
|
|
bl_load_info_t *plat_get_bl_image_load_info(void)
|
|
{
|
|
#if STM32MP_USE_STM32IMAGE
|
|
bl_mem_params_node_t *bl33 = get_bl_mem_params_node(BL33_IMAGE_ID);
|
|
uint32_t ddr_ns_size = stm32mp_get_ddr_ns_size();
|
|
|
|
assert(bl33 != NULL);
|
|
|
|
/* Max size is non-secure DDR end address minus image_base */
|
|
bl33->image_info.image_max_size = STM32MP_DDR_BASE + ddr_ns_size -
|
|
bl33->image_info.image_base;
|
|
#endif /* STM32MP_USE_STM32IMAGE */
|
|
|
|
return get_bl_load_info_from_mem_params_desc();
|
|
}
|
|
|
|
/*******************************************************************************
|
|
* This function returns the list of executable images.
|
|
******************************************************************************/
|
|
bl_params_t *plat_get_next_bl_params(void)
|
|
{
|
|
bl_params_t *bl_params = get_next_bl_params_from_mem_params_desc();
|
|
|
|
populate_next_bl_params_config(bl_params);
|
|
|
|
return bl_params;
|
|
}
|