mirror of
https://github.com/ARM-software/arm-trusted-firmware.git
synced 2025-04-20 19:44:23 +00:00
10c252c14b
If Trusted Firmware is built with optimizations disabled (-O0), the
linker throws the following error:
undefined reference to 'xxx'
Where 'xxx' is a raw inline function defined in a header file. The
reason is that, with optimizations disabled, GCC may decide to skip
the inlining. If that is the case, an external definition to the
compilation unit must be provided. Because no external definition
is present, the linker throws the error.
This patch fixes the problem by declaring the following inline
functions static, so the internal definition is used:
- cm_set_next_context()
- bakery_lock_init()
Note that building the TF with optimizations disabled when Trusted
Board Boot is enabled is currently unsupported, as this makes the BL2
image too big to fit in memory without any adjustment of its base
address. Similarly, disabling optimizations for debug builds on FVP
is unsupported at the moment.
Change-Id: I284a9f84cc8df96a0c1a52dfe05c9e8544c0cefe
109 lines
3.9 KiB
C
109 lines
3.9 KiB
C
/*
|
|
* Copyright (c) 2013-2015, ARM Limited and Contributors. All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions are met:
|
|
*
|
|
* Redistributions of source code must retain the above copyright notice, this
|
|
* list of conditions and the following disclaimer.
|
|
*
|
|
* Redistributions in binary form must reproduce the above copyright notice,
|
|
* this list of conditions and the following disclaimer in the documentation
|
|
* and/or other materials provided with the distribution.
|
|
*
|
|
* Neither the name of ARM nor the names of its contributors may be used
|
|
* to endorse or promote products derived from this software without specific
|
|
* prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
|
|
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
|
|
* ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
|
|
* LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
|
|
* CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
|
|
* SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
|
|
* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
|
|
* CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
|
|
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
|
|
* POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#ifndef __BAKERY_LOCK_H__
|
|
#define __BAKERY_LOCK_H__
|
|
|
|
#include <platform_def.h>
|
|
|
|
#define BAKERY_LOCK_MAX_CPUS PLATFORM_CORE_COUNT
|
|
|
|
#ifndef __ASSEMBLY__
|
|
#include <stdint.h>
|
|
|
|
/*****************************************************************************
|
|
* Internal helper macros used by the bakery lock implementation.
|
|
****************************************************************************/
|
|
/* Convert a ticket to priority */
|
|
#define PRIORITY(t, pos) (((t) << 8) | (pos))
|
|
|
|
#define CHOOSING_TICKET 0x1
|
|
#define CHOSEN_TICKET 0x0
|
|
|
|
#define bakery_is_choosing(info) (info & 0x1)
|
|
#define bakery_ticket_number(info) ((info >> 1) & 0x7FFF)
|
|
#define make_bakery_data(choosing, number) \
|
|
(((choosing & 0x1) | (number << 1)) & 0xFFFF)
|
|
|
|
/*****************************************************************************
|
|
* External bakery lock interface.
|
|
****************************************************************************/
|
|
#if USE_COHERENT_MEM
|
|
/*
|
|
* Bakery locks are stored in coherent memory
|
|
*
|
|
* Each lock's data is contiguous and fully allocated by the compiler
|
|
*/
|
|
|
|
typedef struct bakery_lock {
|
|
/*
|
|
* The lock_data is a bit-field of 2 members:
|
|
* Bit[0] : choosing. This field is set when the CPU is
|
|
* choosing its bakery number.
|
|
* Bits[1 - 15] : number. This is the bakery number allocated.
|
|
*/
|
|
volatile uint16_t lock_data[BAKERY_LOCK_MAX_CPUS];
|
|
} bakery_lock_t;
|
|
|
|
#else
|
|
/*
|
|
* Bakery locks are stored in normal .bss memory
|
|
*
|
|
* Each lock's data is spread across multiple cache lines, one per CPU,
|
|
* but multiple locks can share the same cache line.
|
|
* The compiler will allocate enough memory for one CPU's bakery locks,
|
|
* the remaining cache lines are allocated by the linker script
|
|
*/
|
|
|
|
typedef struct bakery_info {
|
|
/*
|
|
* The lock_data is a bit-field of 2 members:
|
|
* Bit[0] : choosing. This field is set when the CPU is
|
|
* choosing its bakery number.
|
|
* Bits[1 - 15] : number. This is the bakery number allocated.
|
|
*/
|
|
volatile uint16_t lock_data;
|
|
} bakery_info_t;
|
|
|
|
typedef bakery_info_t bakery_lock_t;
|
|
|
|
#endif /* __USE_COHERENT_MEM__ */
|
|
|
|
static inline void bakery_lock_init(bakery_lock_t *bakery) {}
|
|
void bakery_lock_get(bakery_lock_t *bakery);
|
|
void bakery_lock_release(bakery_lock_t *bakery);
|
|
|
|
#define DEFINE_BAKERY_LOCK(_name) bakery_lock_t _name __section("bakery_lock")
|
|
|
|
#define DECLARE_BAKERY_LOCK(_name) extern bakery_lock_t _name
|
|
|
|
|
|
#endif /* __ASSEMBLY__ */
|
|
#endif /* __BAKERY_LOCK_H__ */
|