From f08f6fbfda6038317a1ccaf6203b184ffc6d0eb8 Mon Sep 17 00:00:00 2001 From: Boerge Struempfel Date: Tue, 1 Apr 2025 09:58:47 +0200 Subject: [PATCH] refactor(st-pmic): use LOG_LEVEL for regulator debug output The stpmic2_dump_regulators() function now uses LOG_LEVEL instead of EVENT_LOG_LEVEL to align with general logging conventions. Additionally, the guard has been moved inside the function, removing unnecessary preprocessor checks where the function is used and thereby improving consistency. Change-Id: I087de124e6795a599b4f91a7613c6dfa3f76bb7a Signed-off-by: Boerge Struempfel --- drivers/st/pmic/stm32mp_pmic2.c | 2 -- drivers/st/pmic/stpmic2.c | 4 ++-- include/drivers/st/stpmic2.h | 2 -- 3 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/st/pmic/stm32mp_pmic2.c b/drivers/st/pmic/stm32mp_pmic2.c index c19d36a4a..fcf3fd9aa 100644 --- a/drivers/st/pmic/stm32mp_pmic2.c +++ b/drivers/st/pmic/stm32mp_pmic2.c @@ -493,7 +493,5 @@ void initialize_pmic(void) panic(); } -#if EVENT_LOG_LEVEL == LOG_LEVEL_VERBOSE stpmic2_dump_regulators(pmic2); -#endif } diff --git a/drivers/st/pmic/stpmic2.c b/drivers/st/pmic/stpmic2.c index 7f233db73..b3af3e013 100644 --- a/drivers/st/pmic/stpmic2.c +++ b/drivers/st/pmic/stpmic2.c @@ -434,9 +434,9 @@ int stpmic2_regulator_set_prop(struct pmic_handle_s *pmic, uint8_t id, return -EPERM; } -#if EVENT_LOG_LEVEL == LOG_LEVEL_VERBOSE void stpmic2_dump_regulators(struct pmic_handle_s *pmic) { +#if LOG_LEVEL >= LOG_LEVEL_VERBOSE size_t i; char const *name; @@ -456,8 +456,8 @@ void stpmic2_dump_regulators(struct pmic_handle_s *pmic) VERBOSE("PMIC regul %s: %s, %dmV\n", name, state ? "EN" : "DIS", val); } -} #endif +} int stpmic2_get_version(struct pmic_handle_s *pmic, uint8_t *val) { diff --git a/include/drivers/st/stpmic2.h b/include/drivers/st/stpmic2.h index 58ba64aef..edb56e061 100644 --- a/include/drivers/st/stpmic2.h +++ b/include/drivers/st/stpmic2.h @@ -291,9 +291,7 @@ int stpmic2_regulator_get_voltage(struct pmic_handle_s *pmic, int stpmic2_regulator_set_voltage(struct pmic_handle_s *pmic, uint8_t id, uint16_t millivolts); -#if EVENT_LOG_LEVEL == LOG_LEVEL_VERBOSE void stpmic2_dump_regulators(struct pmic_handle_s *pmic); -#endif int stpmic2_get_version(struct pmic_handle_s *pmic, uint8_t *val); int stpmic2_get_product_id(struct pmic_handle_s *pmic, uint8_t *val);