diff --git a/drivers/imx/usdhc/imx_usdhc.c b/drivers/imx/usdhc/imx_usdhc.c index 07f55b784..49dfc076d 100644 --- a/drivers/imx/usdhc/imx_usdhc.c +++ b/drivers/imx/usdhc/imx_usdhc.c @@ -136,7 +136,8 @@ static int imx_usdhc_send_cmd(struct mmc_cmd *cmd) break; case MMC_CMD(18): multiple = 1; - /* fall thru for read op */ + /* for read op */ + /* fallthrough */ case MMC_CMD(17): case MMC_CMD(8): mixctl |= MIXCTRL_DTDSEL; @@ -144,7 +145,8 @@ static int imx_usdhc_send_cmd(struct mmc_cmd *cmd) break; case MMC_CMD(25): multiple = 1; - /* fall thru for data op flag */ + /* for data op flag */ + /* fallthrough */ case MMC_CMD(24): data = 1; break; diff --git a/drivers/renesas/common/emmc/emmc_cmd.c b/drivers/renesas/common/emmc/emmc_cmd.c index d255bffc9..02fc26bba 100644 --- a/drivers/renesas/common/emmc/emmc_cmd.c +++ b/drivers/renesas/common/emmc/emmc_cmd.c @@ -254,8 +254,7 @@ EMMC_ERROR_CODE emmc_exec_cmd(uint32_t error_mask, uint32_t *response) (SD_INFO2_ALL_ERR | SD_INFO2_CLEAR)); state = ESTATE_ISSUE_CMD; - /* through */ - + /* fallthrough */ case ESTATE_ISSUE_CMD: /* ARG */ SETR_32(SD_ARG, mmc_drv_obj.cmd_info.arg); @@ -454,8 +453,8 @@ EMMC_ERROR_CODE emmc_exec_cmd(uint32_t error_mask, uint32_t *response) SETR_32(SD_STOP, 0x00000000U); mmc_drv_obj.during_dma_transfer = FALSE; } - /* through */ + /* fallthrough */ case ESTATE_ERROR: if (err_not_care_flag == TRUE) { mmc_drv_obj.during_cmd_processing = FALSE; diff --git a/lib/libc/snprintf.c b/lib/libc/snprintf.c index 6a2f0ba7f..0e3256cde 100644 --- a/lib/libc/snprintf.c +++ b/lib/libc/snprintf.c @@ -209,6 +209,7 @@ loop: break; case 'X': capitalise = true; + /* fallthrough */ case 'x': unum = get_unum_va_args(args, l_count); unsigned_num_print(&s, n, &chars_printed, diff --git a/plat/mediatek/common/mtk_smc_handlers.c b/plat/mediatek/common/mtk_smc_handlers.c index 51a960fc3..92b3873c3 100644 --- a/plat/mediatek/common/mtk_smc_handlers.c +++ b/plat/mediatek/common/mtk_smc_handlers.c @@ -51,6 +51,7 @@ x3 = x3 & MASK_32_BIT; \ x4 = x4 & MASK_32_BIT; \ } \ + /* fallthrough */ \ case _smc_id##_AARCH64: \ { \ if (_smc_id##_descriptor_index < 0) { \ diff --git a/plat/nxp/common/psci/plat_psci.c b/plat/nxp/common/psci/plat_psci.c index 9281e97cb..f6dd7b30e 100644 --- a/plat/nxp/common/psci/plat_psci.c +++ b/plat/nxp/common/psci/plat_psci.c @@ -350,7 +350,7 @@ static int _pwr_state_validate(uint32_t pwr_state, else if (SOC_SYSTEM_STANDBY) state->pwr_domain_state[PLAT_MAX_LVL] = PLAT_MAX_RET_STATE; - /* intentional fall-thru condition */ + /* fallthrough */ case PWR_STATE_LVL_SYS: if (pwrdn && SOC_SYSTEM_PWR_DWN) state->pwr_domain_state[PLAT_SYS_LVL] = @@ -358,7 +358,7 @@ static int _pwr_state_validate(uint32_t pwr_state, else if (SOC_SYSTEM_STANDBY) state->pwr_domain_state[PLAT_SYS_LVL] = PLAT_MAX_RET_STATE; - /* intentional fall-thru condition */ + /* fallthrough */ case PWR_STATE_LVL_CLSTR: if (pwrdn && SOC_CLUSTER_PWR_DWN) state->pwr_domain_state[PLAT_CLSTR_LVL] = @@ -366,7 +366,7 @@ static int _pwr_state_validate(uint32_t pwr_state, else if (SOC_CLUSTER_STANDBY) state->pwr_domain_state[PLAT_CLSTR_LVL] = PLAT_MAX_RET_STATE; - /* intentional fall-thru condition */ + /* fallthrough */ case PWR_STATE_LVL_CORE: stat = PSCI_E_SUCCESS; diff --git a/services/std_svc/spmd/spmd_main.c b/services/std_svc/spmd/spmd_main.c index 7e6c89df3..afd0f2ea2 100644 --- a/services/std_svc/spmd/spmd_main.c +++ b/services/std_svc/spmd/spmd_main.c @@ -868,7 +868,8 @@ uint64_t spmd_smc_handler(uint32_t smc_fid, FFA_ERROR_NOT_SUPPORTED); } - /* Fall through to forward the call to the other world */ + /* Forward the call to the other world */ + /* fallthrough */ case FFA_MSG_SEND: case FFA_MSG_SEND_DIRECT_RESP_SMC64: case FFA_MEM_DONATE_SMC32: @@ -908,7 +909,8 @@ uint64_t spmd_smc_handler(uint32_t smc_fid, spmd_spm_core_sync_exit(0ULL); } - /* Fall through to forward the call to the other world */ + /* Forward the call to the other world */ + /* fallthrough */ case FFA_INTERRUPT: case FFA_MSG_YIELD: /* This interface must be invoked only by the Secure world */