From cf237f8d55255da1aad4f8dccb3110bab6060eba Mon Sep 17 00:00:00 2001 From: Yann Gautier Date: Thu, 2 Nov 2023 15:36:12 +0100 Subject: [PATCH] feat(st-bsec): use early traces Replace trace macros with their corresponding EARLY_* macros. Add some early traces in bsec2 driver. Change-Id: I65e2feee6e7ba2524fb0a334557aa6e883672765 Signed-off-by: Yann Gautier --- drivers/st/bsec/bsec2.c | 16 +++++++++++++--- drivers/st/bsec/bsec3.c | 2 +- 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/drivers/st/bsec/bsec2.c b/drivers/st/bsec/bsec2.c index a6e522094..db07d1c5c 100644 --- a/drivers/st/bsec/bsec2.c +++ b/drivers/st/bsec/bsec2.c @@ -166,11 +166,13 @@ static void bsec_late_init(void) struct dt_node_info bsec_info; if (fdt_get_address(&fdt) == 0) { + EARLY_ERROR("%s: DT not found\n", __func__); panic(); } node = bsec_get_dt_node(&bsec_info); if (node < 0) { + EARLY_ERROR("%s: BSEC node not found\n", __func__); panic(); } @@ -226,13 +228,21 @@ static uint32_t bsec_check_error(uint32_t otp, bool check_disturbed) */ uint32_t bsec_probe(void) { + uint32_t version; + uint32_t id; + if (is_otp_invalid_mode()) { + EARLY_ERROR("%s: otp_invalid_mod\n", __func__); return BSEC_ERROR; } - if (((bsec_get_version() != BSEC_IP_VERSION_1_1) && - (bsec_get_version() != BSEC_IP_VERSION_2_0)) || - (bsec_get_id() != BSEC_IP_ID_2)) { + version = bsec_get_version(); + id = bsec_get_id(); + + if (((version != BSEC_IP_VERSION_1_1) && + (version != BSEC_IP_VERSION_2_0)) || + (id != BSEC_IP_ID_2)) { + EARLY_ERROR("%s: version = 0x%x, id = 0x%x\n", __func__, version, id); panic(); } diff --git a/drivers/st/bsec/bsec3.c b/drivers/st/bsec/bsec3.c index a803a3a9c..3fdaf16fb 100644 --- a/drivers/st/bsec/bsec3.c +++ b/drivers/st/bsec/bsec3.c @@ -188,7 +188,7 @@ uint32_t bsec_probe(void) uint32_t id = bsec_get_id(); if ((version != BSEC_IP_VERSION_1_0) || (id != BSEC_IP_ID_3)) { - ERROR("%s: version = 0x%x, id = 0x%x\n", __func__, version, id); + EARLY_ERROR("%s: version = 0x%x, id = 0x%x\n", __func__, version, id); panic(); }