From bdbbf48f4db6fa64079efcd284955a3bf629b705 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Maxime=20M=C3=A9r=C3=A9?= Date: Thu, 26 Sep 2024 09:29:49 +0200 Subject: [PATCH] fix(st-pmic): remove deadcode from STPMIC2 driver MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit "regul" corresponds to a specific part of a global table that can't be undefined. Thus, checking if it is NULL is useless. Issue found by Coverity (CID 445089). Signed-off-by: Maxime Méré Change-Id: Ic812bc1fde12fe8389677c7c72fb85246c50f5c9 --- drivers/st/pmic/stpmic2.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/st/pmic/stpmic2.c b/drivers/st/pmic/stpmic2.c index 05a80ecf1..7f233db73 100644 --- a/drivers/st/pmic/stpmic2.c +++ b/drivers/st/pmic/stpmic2.c @@ -1,5 +1,5 @@ /* - * Copyright (C) 2024, STMicroelectronics - All Rights Reserved + * Copyright (C) 2024-2025, STMicroelectronics - All Rights Reserved * * SPDX-License-Identifier: BSD-3-Clause */ @@ -247,10 +247,6 @@ int stpmic2_regulator_levels_mv(struct pmic_handle_s *pmic, { const struct regul_struct *regul = ®ul_table[id]; - if (regul == NULL) { - return RET_ERROR_BAD_PARAMETERS; - } - if (levels_count != NULL) { *levels_count = regul->volt_table_size; }