diff --git a/plat/xilinx/zynqmp/plat_psci.c b/plat/xilinx/zynqmp/plat_psci.c index 526e21538..2bab7f0a9 100644 --- a/plat/xilinx/zynqmp/plat_psci.c +++ b/plat/xilinx/zynqmp/plat_psci.c @@ -169,7 +169,7 @@ static void __dead2 zynqmp_system_off(void) pm_system_shutdown(PMF_SHUTDOWN_TYPE_SHUTDOWN, pm_get_shutdown_scope()); - while (1) { + while (true) { wfi(); } } @@ -183,7 +183,7 @@ static void __dead2 zynqmp_system_reset(void) pm_system_shutdown(PMF_SHUTDOWN_TYPE_RESET, pm_get_shutdown_scope()); - while (1) { + while (true) { wfi(); } } @@ -204,7 +204,7 @@ static int32_t zynqmp_validate_power_state(uint32_t power_state, req_state->pwr_domain_state[MPIDR_AFFLVL0] = PLAT_MAX_OFF_STATE; } /* We expect the 'state id' to be zero */ - if (psci_get_pstate_id(power_state)) { + if (psci_get_pstate_id(power_state) != 0U) { return PSCI_E_INVALID_PARAMS; } diff --git a/plat/xilinx/zynqmp/plat_zynqmp.c b/plat/xilinx/zynqmp/plat_zynqmp.c index e3a979ea6..65faa2fc2 100644 --- a/plat/xilinx/zynqmp/plat_zynqmp.c +++ b/plat/xilinx/zynqmp/plat_zynqmp.c @@ -10,7 +10,7 @@ int32_t plat_core_pos_by_mpidr(u_register_t mpidr) { - if (mpidr & MPIDR_CLUSTER_MASK) { + if ((mpidr & MPIDR_CLUSTER_MASK) != 0U) { return -1; } diff --git a/plat/xilinx/zynqmp/pm_service/pm_api_clock.c b/plat/xilinx/zynqmp/pm_service/pm_api_clock.c index ee4f07d8f..22919574e 100644 --- a/plat/xilinx/zynqmp/pm_service/pm_api_clock.c +++ b/plat/xilinx/zynqmp/pm_service/pm_api_clock.c @@ -2684,8 +2684,8 @@ enum pm_ret_status pm_api_clock_get_max_divisor(enum clock_id clock_id, nodes = *clocks[clock_id].nodes; for (i = 0; i < clocks[clock_id].num_nodes; i++) { if (nodes[i].type == div_type) { - if (CLK_DIVIDER_POWER_OF_TWO & - nodes[i].typeflags) { + if ((CLK_DIVIDER_POWER_OF_TWO & + nodes[i].typeflags) != 0U) { *max_div = (1U << (BIT(nodes[i].width) - 1U)); } else { *max_div = BIT(nodes[i].width) - 1U; diff --git a/plat/xilinx/zynqmp/pm_service/pm_api_ioctl.c b/plat/xilinx/zynqmp/pm_service/pm_api_ioctl.c index aea607c53..0dbfa57de 100644 --- a/plat/xilinx/zynqmp/pm_service/pm_api_ioctl.c +++ b/plat/xilinx/zynqmp/pm_service/pm_api_ioctl.c @@ -62,7 +62,7 @@ static enum pm_ret_status pm_ioctl_set_rpu_oper_mode(uint32_t mode) { uint32_t val; - if (mmio_read_32(CRL_APB_RST_LPD_TOP) & CRL_APB_RPU_AMBA_RESET) { + if ((mmio_read_32(CRL_APB_RST_LPD_TOP) & CRL_APB_RPU_AMBA_RESET) != 0U) { return PM_RET_ERROR_ACCESS; } diff --git a/plat/xilinx/zynqmp/pm_service/pm_client.c b/plat/xilinx/zynqmp/pm_service/pm_client.c index 716ebb692..a51725754 100644 --- a/plat/xilinx/zynqmp/pm_service/pm_client.c +++ b/plat/xilinx/zynqmp/pm_service/pm_client.c @@ -204,7 +204,7 @@ static void pm_client_set_wakeup_sources(void) continue; } - while (reg) { + while (reg != 0U) { enum pm_node_id node; uint32_t idx, ret, irq, lowest_set = reg & (-reg); diff --git a/plat/xilinx/zynqmp/pm_service/zynqmp_pm_api_sys.c b/plat/xilinx/zynqmp/pm_service/zynqmp_pm_api_sys.c index 5456689c0..079f89e50 100644 --- a/plat/xilinx/zynqmp/pm_service/zynqmp_pm_api_sys.c +++ b/plat/xilinx/zynqmp/pm_service/zynqmp_pm_api_sys.c @@ -1115,7 +1115,7 @@ static enum pm_ret_status pm_clock_gate(uint32_t clock_id, return status; } - if (enable) { + if (enable != 0U) { api_id = PM_CLOCK_ENABLE; } else { api_id = PM_CLOCK_DISABLE; @@ -1297,7 +1297,7 @@ enum pm_ret_status pm_clock_getdivider(uint32_t clock_id, return status; } - if (pm_clock_has_div(clock_id, PM_CLOCK_DIV0_ID)) { + if ((pm_clock_has_div(clock_id, PM_CLOCK_DIV0_ID)) != 0U) { /* Send request to the PMU to get div0 */ PM_PACK_PAYLOAD3(payload, PM_CLOCK_GETDIVIDER, clock_id, PM_CLOCK_DIV0_ID); @@ -1308,7 +1308,7 @@ enum pm_ret_status pm_clock_getdivider(uint32_t clock_id, *divider = val; } - if (pm_clock_has_div(clock_id, PM_CLOCK_DIV1_ID)) { + if ((pm_clock_has_div(clock_id, PM_CLOCK_DIV1_ID)) != 0U) { /* Send request to the PMU to get div1 */ PM_PACK_PAYLOAD3(payload, PM_CLOCK_GETDIVIDER, clock_id, PM_CLOCK_DIV1_ID); diff --git a/plat/xilinx/zynqmp/sip_svc_setup.c b/plat/xilinx/zynqmp/sip_svc_setup.c index f5990ca59..1baefb3c9 100644 --- a/plat/xilinx/zynqmp/sip_svc_setup.c +++ b/plat/xilinx/zynqmp/sip_svc_setup.c @@ -81,7 +81,7 @@ static uintptr_t sip_svc_smc_handler(uint32_t smc_fid, VERBOSE("SMCID: 0x%08x, x1: 0x%016" PRIx64 ", x2: 0x%016" PRIx64 ", x3: 0x%016" PRIx64 ", x4: 0x%016" PRIx64 "\n", smc_fid, x1, x2, x3, x4); - if (smc_fid & SIP_FID_MASK) { + if ((smc_fid & (uint32_t)SIP_FID_MASK) != 0U) { WARN("SMC out of SiP assinged range: 0x%x\n", smc_fid); SMC_RET1(handle, SMC_UNK); }