Djam/arm-trusted-firmware
1
0
Fork 0
mirror of https://github.com/ARM-software/arm-trusted-firmware.git synced 2025-04-25 06:19:56 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(cpus): update doc and check for plat_can_cmo

Browse source 
plat_can_cmo must not clobber x1 but the doc doesn't mention that. This
patch updates the doc to mention x1. It also adds check for plat_can_cmo
to `dcsw_op_louis` which was missed out in original patch.

Signed-off-by: Okash Khawaja <okash@google.com>
Change-Id: I721376bf3726520d0d5b0df0f33f98ce92257287
This commit is contained in:
Okash Khawaja 2022-11-14 12:50:30 +00:00 • committed by Manish Pandey
parent c3170fd80b
commit a2e0123484
2 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
docs/getting_started/porting-guide.rst
View file

@ -1502,8 +1502,8 @@ When CONDITIONAL_CMO flag is enabled:
- This function indicates whether cache management operations should be - This function indicates whether cache management operations should be
performed. It returns 0 if CMOs should be skipped and non-zero performed. It returns 0 if CMOs should be skipped and non-zero
otherwise. otherwise.
- The function must not clobber x2 and x3. It's also not safe to rely on stack. - The function must not clobber x1, x2 and x3. It's also not safe to rely on
Otherwise obey AAPCS. stack. Otherwise obey AAPCS.
Modifications specific to a Boot Loader stage Modifications specific to a Boot Loader stage
--------------------------------------------- ---------------------------------------------

1
lib/aarch64/cache_helpers.S
View file

@ -217,6 +217,7 @@ dcsw_loop_table:
func dcsw_op_louis func dcsw_op_louis
check_plat_can_cmo
dcsw_op #LOUIS_SHIFT, #CLIDR_FIELD_WIDTH, #LEVEL_SHIFT dcsw_op #LOUIS_SHIFT, #CLIDR_FIELD_WIDTH, #LEVEL_SHIFT
endfunc dcsw_op_louis endfunc dcsw_op_louis