mirror of
https://github.com/ARM-software/arm-trusted-firmware.git
synced 2025-05-08 18:41:22 +00:00
Ensure the flow through switch statements is clear
Ensure case clauses: * Terminate with an unconditional break, return or goto statement. * Use conditional break, return or goto statements as long as the end of the case clause is unreachable; such case clauses must terminate with assert(0) /* Unreachable */ or an unconditional __dead2 function call * Only fallthough when doing otherwise would result in less readable/maintainable code; such case clauses must terminate with a /* Fallthrough */ comment to make it clear this is the case and indicate that a fallthrough is intended. This reduces the chance of bugs appearing due to unintended flow through a switch statement Change-Id: I70fc2d1f4fd679042397dec12fd1982976646168 Signed-off-by: Daniel Boulby <daniel.boulby@arm.com>
This commit is contained in:
parent
e52ed092cd
commit
a08a201430
9 changed files with 16 additions and 9 deletions
|
@ -166,6 +166,7 @@ loop:
|
|||
padn = (padn * 10) + (ch - '0');
|
||||
fmt++;
|
||||
}
|
||||
assert(0); /* Unreachable */
|
||||
default:
|
||||
/* Exit on any other format specifier */
|
||||
return -1;
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue