Djam/arm-trusted-firmware
1
0
Fork 0
mirror of https://github.com/ARM-software/arm-trusted-firmware.git synced 2025-04-26 23:04:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Make the BL3-1 crash reporting optional

Browse source 
This patch makes the console crash dump of processor register
state optional based on the CRASH_REPORTING make variable.

This defaults to only being enabled for DEBUG builds. This can
be overridden by setting a different value in the platform
makefile or on the make command line.

Change-Id: Icfa1b2d7ff0145cf0a85e8ad732f9cee7e7e993f
This commit is contained in:
Andrew Thoelke 2014-06-03 11:50:53 +01:00
parent 977fbcd4e0
commit 9c22b32300
4 changed files with 23 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
bl31/aarch64/crash_reporting.S
View file

@ -36,6 +36,7 @@
.globl dump_state_and_die .globl dump_state_and_die
.globl dump_intr_state_and_die .globl dump_intr_state_and_die
#if CRASH_REPORTING
/* ------------------------------------------------------ /* ------------------------------------------------------
* The below section deals with dumping the system state * The below section deals with dumping the system state
* when an unhandled exception is taken in EL3. * when an unhandled exception is taken in EL3.
@ -264,9 +265,15 @@ print_state:
print_el3_sys_regs print_el3_sys_regs
print_non_el3_sys_0_regs print_non_el3_sys_0_regs
print_non_el3_sys_1_regs print_non_el3_sys_1_regs
b infinite_loop
func infinite_loop #else /* CRASH_REPORING */
func dump_state_and_die
dump_intr_state_and_die:
#endif /* CRASH_REPORING */
infinite_loop:
b infinite_loop b infinite_loop

8
bl31/bl31.mk
View file

@ -59,3 +59,11 @@ IMF_READ_INTERRUPT_ID := 0
$(eval $(call assert_boolean,IMF_READ_INTERRUPT_ID)) $(eval $(call assert_boolean,IMF_READ_INTERRUPT_ID))
$(eval $(call add_define,IMF_READ_INTERRUPT_ID)) $(eval $(call add_define,IMF_READ_INTERRUPT_ID))
# Flag used to inidicate if Crash reporting via console should be included
# in BL3-1. This defaults to being present in DEBUG builds only
ifndef CRASH_REPORTING
CRASH_REPORTING := $(DEBUG)
endif
$(eval $(call assert_boolean,CRASH_REPORTING))
$(eval $(call add_define,CRASH_REPORTING))

2
bl31/context_mgmt.c
View file

@ -285,7 +285,9 @@ void cm_init_pcpu_ptr_cache()
pcpu_ptr_cache = &per_cpu_ptr_cache_space[linear_id]; pcpu_ptr_cache = &per_cpu_ptr_cache_space[linear_id];
assert(pcpu_ptr_cache); assert(pcpu_ptr_cache);
#if CRASH_REPORTING
pcpu_ptr_cache->crash_stack = get_crash_stack(mpidr); pcpu_ptr_cache->crash_stack = get_crash_stack(mpidr);
#endif
cm_set_pcpu_ptr_cache(pcpu_ptr_cache); cm_set_pcpu_ptr_cache(pcpu_ptr_cache);
} }

4
docs/user-guide.md
View file

@ -172,6 +172,10 @@ performed.
entrypoint) or 1 (CPU reset to BL3-1 entrypoint). entrypoint) or 1 (CPU reset to BL3-1 entrypoint).
The default value is 0. The default value is 0.
* `CRASH_REPORTING`: A non-zero value enables a console dump of processor
register state when an unexpected exception occurs during execution of
BL3-1. This option defaults to the value of `DEBUG` - i.e. by default
this is only enabled for a debug build of the firmware.
### Creating a Firmware Image Package ### Creating a Firmware Image Package