Djam/arm-trusted-firmware
1
0
Fork 0
mirror of https://github.com/ARM-software/arm-trusted-firmware.git synced 2025-04-11 07:04:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

feat(rmmd): verify FEAT_MEC present before calling plat hoook

Browse source 
Some platforms do not support FEAT_MEC. Hence, they do not provide
an interface to update the update of the key corresponding to a
MECID.

This patch adds a condition in order to verify FEAT_MEC is present
before calling the corresponding platform hook, thus preventing it
from being called when the platform does not support the feature.

Change-Id: Ib1eb9e42f475e27ec31529569e888b93b207148c
Signed-off-by: Juan Pablo Conde <juanpablo.conde@arm.com>
This commit is contained in:
Juan Pablo Conde 2025-03-24 16:18:48 -05:00 • committed by Soby Mathew
parent b78c307ca6
commit 609ada9691
3 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
include/plat/common/platform.h
View file

@ -399,7 +399,7 @@ int plat_rmmd_el3_token_sign_pull_resp(struct el3_token_sign_response *resp);
size_t plat_rmmd_get_el3_rmm_shared_mem(uintptr_t *shared);
int plat_rmmd_load_manifest(struct rmm_manifest *manifest);
int plat_rmmd_mecid_key_update(uint16_t mecid);
#endif
#endif /* ENABLE_RME */
/*******************************************************************************
* Optional BL31 functions (may be overridden)

3
plat/arm/board/neoverse_rd/platform/rdv3/rdv3_common.c
View file

@ -193,7 +193,8 @@ int plat_rmmd_load_manifest(struct rmm_manifest *manifest)
int plat_rmmd_mecid_key_update(uint16_t mecid)
{
/*
* TODO
* RDV3 does not support FEAT_MEC.
* This empty hook is for compilation to succeed.
*/
return 0;
}

8
services/std_svc/rmmd/rmmd_main.c
View file

@ -478,6 +478,14 @@ static int rmmd_mecid_key_update(uint64_t mecid)
uint64_t mecid_width, mecid_width_mask;
int ret;
/*
* Check whether FEAT_MEC is supported by the hardware. If not, return
* unknown SMC.
*/
if (is_feat_mec_supported() == false) {
return E_RMM_UNK;
}
/*
* Check whether the mecid parameter is at most MECIDR_EL2.MECIDWidthm1 + 1
* in length.