Djam/arm-trusted-firmware
1
0
Fork 0
mirror of https://github.com/ARM-software/arm-trusted-firmware.git synced 2025-04-27 23:35:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Improve debug assertion for runtime svc number

Browse source 
This patch improves the debug assertion for runtime svc number
 - Remove useless comparison ensuring that the number of descriptors
   is a positive number. The variable is an unsigned integer so can't
   be negative.
 - Check that the end address of the descriptors is sane relative
   to the start address.

Change-Id: Iea7be6b34e33b8b1cbd394eb923cc834ea964831
This commit is contained in:
Soby Mathew 2016-07-26 16:09:44 +01:00
parent 3dd9835f8a
commit 5e5e41625e
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
common/runtime_svc.c
View file

@ -87,7 +87,8 @@ void runtime_svc_init(void)
int rc = 0, index, start_idx, end_idx; int rc = 0, index, start_idx, end_idx;
/* Assert the number of descriptors detected are less than maximum indices */ /* Assert the number of descriptors detected are less than maximum indices */
assert((RT_SVC_DECS_NUM >= 0) && (RT_SVC_DECS_NUM < MAX_RT_SVCS)); assert((RT_SVC_DESCS_END >= RT_SVC_DESCS_START) &&
(RT_SVC_DECS_NUM < MAX_RT_SVCS));
/* If no runtime services are implemented then simply bail out */ /* If no runtime services are implemented then simply bail out */
if (RT_SVC_DECS_NUM == 0) if (RT_SVC_DECS_NUM == 0)