From 5c457689b283437cbf1ba87c48bae9e03a579aa8 Mon Sep 17 00:00:00 2001 From: Patrick Delaunay Date: Tue, 28 Nov 2023 11:35:51 +0100 Subject: [PATCH] fix(stm32mp1): remove unnecessary assert on GPIO_BANK_A value Remove assert for unexpected value of the define GPIO_BANK_A. This check is not required as GPIO_BANK_A = 0, it can be limited to have bank <= GPIO_BANK_K as bank is unsigned int. Signed-off-by: Patrick Delaunay Change-Id: I0345d56f106fcacd6a6f93281c2d9279980cd152 --- plat/st/stm32mp1/stm32mp1_private.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/plat/st/stm32mp1/stm32mp1_private.c b/plat/st/stm32mp1/stm32mp1_private.c index f098eb37e..509bb11de 100644 --- a/plat/st/stm32mp1/stm32mp1_private.c +++ b/plat/st/stm32mp1/stm32mp1_private.c @@ -115,14 +115,14 @@ void configure_mmu(void) uintptr_t stm32_get_gpio_bank_base(unsigned int bank) { #if STM32MP13 - assert((GPIO_BANK_A == 0) && (bank <= GPIO_BANK_I)); + assert(bank <= GPIO_BANK_I); #endif #if STM32MP15 if (bank == GPIO_BANK_Z) { return GPIOZ_BASE; } - assert((GPIO_BANK_A == 0) && (bank <= GPIO_BANK_K)); + assert(bank <= GPIO_BANK_K); #endif return GPIOA_BASE + (bank * GPIO_BANK_OFFSET); @@ -131,14 +131,14 @@ uintptr_t stm32_get_gpio_bank_base(unsigned int bank) uint32_t stm32_get_gpio_bank_offset(unsigned int bank) { #if STM32MP13 - assert((GPIO_BANK_A == 0) && (bank <= GPIO_BANK_I)); + assert(bank <= GPIO_BANK_I); #endif #if STM32MP15 if (bank == GPIO_BANK_Z) { return 0; } - assert((GPIO_BANK_A == 0) && (bank <= GPIO_BANK_K)); + assert(bank <= GPIO_BANK_K); #endif return bank * GPIO_BANK_OFFSET; @@ -161,14 +161,14 @@ bool stm32_gpio_is_secure_at_reset(unsigned int bank) unsigned long stm32_get_gpio_bank_clock(unsigned int bank) { #if STM32MP13 - assert((GPIO_BANK_A == 0) && (bank <= GPIO_BANK_I)); + assert(bank <= GPIO_BANK_I); #endif #if STM32MP15 if (bank == GPIO_BANK_Z) { return GPIOZ; } - assert((GPIO_BANK_A == 0) && (bank <= GPIO_BANK_K)); + assert(bank <= GPIO_BANK_K); #endif return GPIOA + (bank - GPIO_BANK_A);