Djam/arm-trusted-firmware
1
0
Fork 0
mirror of https://github.com/ARM-software/arm-trusted-firmware.git synced 2025-04-15 09:04:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Move assembly newline function into common debug code

Browse source 
Printing a newline is a relatively common functionality for code to want
to do. Therefore, this patch now moves this function into a common part
of the code that anyone can use.

Change-Id: I2cad699fde00ef8d2aabf8bf35742ddd88d090ba
Signed-off-by: Justin Chadwell <justin.chadwell@arm.com>
This commit is contained in:
Justin Chadwell 2019-08-20 10:58:49 +01:00 • committed by Paul Beesley
parent 3441952f61
commit 53d7e003fe
2 changed files with 12 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
bl31/aarch64/crash_reporting.S
View file

@ -61,14 +61,6 @@ excpt_msg:
intr_excpt_msg: intr_excpt_msg:
.asciz "Unhandled Interrupt Exception in EL3.\nx30" .asciz "Unhandled Interrupt Exception in EL3.\nx30"
/*
* Helper function to print newline to console.
*/
func print_newline
mov x0, '\n'
b plat_crash_console_putc
endfunc print_newline
/* /*
* Helper function to print from crash buf. * Helper function to print from crash buf.
* The print loop is controlled by the buf size and * The print loop is controlled by the buf size and
@ -101,7 +93,7 @@ test_size_list:
bl print_alignment bl print_alignment
ldr x4, [x7], #REGSZ ldr x4, [x7], #REGSZ
bl asm_print_hex bl asm_print_hex
bl print_newline bl asm_print_newline
b test_size_list b test_size_list
exit_size_print: exit_size_print:
mov x30, sp mov x30, sp
@ -253,7 +245,7 @@ func do_crash_reporting
/* report x30 first from the crash buf */ /* report x30 first from the crash buf */
ldr x4, [x0, #REGSZ * 7] ldr x4, [x0, #REGSZ * 7]
bl asm_print_hex bl asm_print_hex
bl print_newline bl asm_print_newline
/* Load the crash buf address */ /* Load the crash buf address */
mrs x0, tpidr_el3 mrs x0, tpidr_el3
/* Now mov x7 into crash buf */ /* Now mov x7 into crash buf */

10
common/aarch64/debug.S
View file

@ -11,6 +11,7 @@
.globl asm_print_str .globl asm_print_str
.globl asm_print_hex .globl asm_print_hex
.globl asm_print_hex_bits .globl asm_print_hex_bits
.globl asm_print_newline
.globl asm_assert .globl asm_assert
.globl do_panic .globl do_panic
@ -130,6 +131,15 @@ asm_print_hex_bits:
ret x3 ret x3
endfunc asm_print_hex endfunc asm_print_hex
/*
* Helper function to print newline to console
* Clobber: x0
*/
func asm_print_newline
mov x0, '\n'
b plat_crash_console_putc
endfunc asm_print_newline
/*********************************************************** /***********************************************************
* The common implementation of do_panic for all BL stages * The common implementation of do_panic for all BL stages
***********************************************************/ ***********************************************************/