Djam/arm-trusted-firmware
1
0
Fork 0
mirror of https://github.com/ARM-software/arm-trusted-firmware.git synced 2025-04-23 13:36:05 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(layerscape): fix coverity issue

Browse source 
Check return value of mmap_add_dynamic_region().

Signed-off-by: Jiafei Pan <Jiafei.Pan@nxp.com>
Change-Id: I84e257b3052371e18af158c3254f42a1bae0da10
This commit is contained in:
Jiafei Pan 2022-03-29 15:01:09 +08:00
parent f713e5954e
commit 5161cfde9b
2 changed files with 24 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
plat/nxp/common/img_loadr/load_img.c
View file

@ -1,5 +1,5 @@
/* /*
* Copyright 2018-2020 NXP * Copyright 2018-2022 NXP
* *
* SPDX-License-Identifier: BSD-3-Clause * SPDX-License-Identifier: BSD-3-Clause
* *
@ -49,10 +49,14 @@ int load_img(unsigned int image_id, uintptr_t *image_base,
/* Create MMU entry for the CSF header */ /* Create MMU entry for the CSF header */
#if PLAT_XLAT_TABLES_DYNAMIC #if PLAT_XLAT_TABLES_DYNAMIC
#ifdef CSF_HEADER_PREPENDED #ifdef CSF_HEADER_PREPENDED
mmap_add_dynamic_region(img_info.image_info.image_base, err = mmap_add_dynamic_region(img_info.image_info.image_base,
img_info.image_info.image_base, img_info.image_info.image_base,
CSF_HDR_SZ, CSF_HDR_SZ,
MT_MEMORY | MT_RW | MT_SECURE); MT_MEMORY | MT_RW | MT_SECURE);
if (err != 0) {
ERROR("Failed to add dynamic memory region.\n");
return err;
}
#endif #endif
#endif #endif

23
plat/nxp/common/setup/ls_common.c
View file

@ -1,5 +1,5 @@
/* /*
* Copyright 2018-2021 NXP * Copyright 2018-2022 NXP
* *
* SPDX-License-Identifier: BSD-3-Clause * SPDX-License-Identifier: BSD-3-Clause
* *
@ -113,7 +113,8 @@ static void mmap_add_ddr_regions_statically(void)
#if defined(PLAT_XLAT_TABLES_DYNAMIC) #if defined(PLAT_XLAT_TABLES_DYNAMIC)
void mmap_add_ddr_region_dynamically(void) void mmap_add_ddr_region_dynamically(void)
{ {
int i = 0; int ret, i = 0;
dram_regions_info_t *info_dram_regions = get_dram_regions_info(); dram_regions_info_t *info_dram_regions = get_dram_regions_info();
/* MMU map for Non-Secure DRAM Regions */ /* MMU map for Non-Secure DRAM Regions */
VERBOSE("DRAM Region %d: %p - %p\n", i, VERBOSE("DRAM Region %d: %p - %p\n", i,
@ -121,10 +122,14 @@ void mmap_add_ddr_region_dynamically(void)
(void *) (info_dram_regions->region[i].addr (void *) (info_dram_regions->region[i].addr
+ info_dram_regions->region[i].size + info_dram_regions->region[i].size
- 1)); - 1));
mmap_add_dynamic_region(info_dram_regions->region[i].addr, ret = mmap_add_dynamic_region(info_dram_regions->region[i].addr,
info_dram_regions->region[i].addr, info_dram_regions->region[i].addr,
info_dram_regions->region[i].size, info_dram_regions->region[i].size,
MT_MEMORY | MT_RW | MT_NS); MT_MEMORY | MT_RW | MT_NS);
if (ret != 0) {
ERROR("Failed to add dynamic memory region\n");
panic();
}
/* MMU map for Secure DDR Region on DRAM-0 */ /* MMU map for Secure DDR Region on DRAM-0 */
if (info_dram_regions->region[i].size > if (info_dram_regions->region[i].size >
@ -137,12 +142,16 @@ void mmap_add_ddr_region_dynamically(void)
+ NXP_SECURE_DRAM_SIZE + NXP_SECURE_DRAM_SIZE
+ NXP_SP_SHRD_DRAM_SIZE + NXP_SP_SHRD_DRAM_SIZE
- 1)); - 1));
mmap_add_dynamic_region((info_dram_regions->region[i].addr ret = mmap_add_dynamic_region((info_dram_regions->region[i].addr
+ info_dram_regions->region[i].size), + info_dram_regions->region[i].size),
(info_dram_regions->region[i].addr (info_dram_regions->region[i].addr
+ info_dram_regions->region[i].size), + info_dram_regions->region[i].size),
(NXP_SECURE_DRAM_SIZE + NXP_SP_SHRD_DRAM_SIZE), (NXP_SECURE_DRAM_SIZE + NXP_SP_SHRD_DRAM_SIZE),
MT_MEMORY | MT_RW | MT_SECURE); MT_MEMORY | MT_RW | MT_SECURE);
if (ret != 0) {
ERROR("Failed to add dynamic memory region\n");
panic();
}
} }
#ifdef IMAGE_BL31 #ifdef IMAGE_BL31
@ -155,10 +164,14 @@ void mmap_add_ddr_region_dynamically(void)
(void *) (info_dram_regions->region[i].addr (void *) (info_dram_regions->region[i].addr
+ info_dram_regions->region[i].size + info_dram_regions->region[i].size
- 1)); - 1));
mmap_add_dynamic_region(info_dram_regions->region[i].addr, ret = mmap_add_dynamic_region(info_dram_regions->region[i].addr,
info_dram_regions->region[i].addr, info_dram_regions->region[i].addr,
info_dram_regions->region[i].size, info_dram_regions->region[i].size,
MT_MEMORY | MT_RW | MT_NS); MT_MEMORY | MT_RW | MT_NS);
if (ret != 0) {
ERROR("Failed to add dynamic memory region\n");
panic();
}
} }
#endif #endif
} }