Djam/arm-trusted-firmware
1
0
Fork 0
mirror of https://github.com/ARM-software/arm-trusted-firmware.git synced 2025-04-16 01:24:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

stm32mp1: correct some static analysis tools issues

Browse source 
These issues wer found by sparse:

drivers/st/clk/stm32mp1_clk.c:1524:19:
 warning: incorrect type in assignment (different base types)
    expected restricted fdt32_t const [usertype] *pkcs_cell
    got unsigned int const [usertype] *

plat/st/stm32mp1/plat_image_load.c:13:6:
 warning: symbol 'plat_flush_next_bl_params' was not declared.
 Should it be static?
plat/st/stm32mp1/plat_image_load.c:21:16:
 warning: symbol 'plat_get_bl_image_load_info' was not declared.
 Should it be static?
plat/st/stm32mp1/plat_image_load.c:29:13:
 warning: symbol 'plat_get_next_bl_params' was not declared.
 Should it be static?

plat/st/stm32mp1/bl2_io_storage.c:40:10:
 warning: symbol 'block_buffer' was not declared. Should it be static?

Signed-off-by: Yann Gautier <yann.gautier@st.com>
This commit is contained in:
Yann Gautier 2018-11-09 15:57:18 +01:00
parent 4cb17707b5
commit 3e6fab4308
5 changed files with 9 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/st/clk/stm32mp1_clk.c
View file

@ -1323,7 +1323,7 @@ int stm32mp1_clk_init(void)
int ret, len;
enum stm32mp1_pll_id i;
bool lse_css = false;
const uint32_t *pkcs_cell;
const fdt32_t *pkcs_cell;
/* Check status field to disable security */
if (!fdt_get_rcc_secure_status()) {
@ -1529,7 +1529,7 @@ int stm32mp1_clk_init(void)
priv->pkcs_usb_value = 0;
for (j = 0; j < ((uint32_t)len / sizeof(uint32_t)); j++) {
uint32_t pkcs = (uint32_t)fdt32_to_cpu(pkcs_cell[j]);
uint32_t pkcs = fdt32_to_cpu(pkcs_cell[j]);
if (pkcs == (uint32_t)CLK_CKPER_DISABLED) {
ckper_disabled = true;

6
drivers/st/clk/stm32mp1_clkfunc.c
View file

@ -265,11 +265,11 @@ int fdt_rcc_subnode_offset(const char *name)
* This function gets the pointer to a rcc-clk property from its name.
* It reads the values indicated inside the device tree.
* Length of the property is stored in the second parameter.
* Returns pointer if success, and NULL value else.
* Returns pointer on success, and NULL value on failure.
******************************************************************************/
const uint32_t *fdt_rcc_read_prop(const char *prop_name, int *lenp)
const fdt32_t *fdt_rcc_read_prop(const char *prop_name, int *lenp)
{
const uint32_t *cuint;
const fdt32_t *cuint;
int node, len;
void *fdt;

3
include/drivers/st/stm32mp1_clkfunc.h
View file

@ -7,6 +7,7 @@
#ifndef STM32MP1_CLKFUNC_H
#define STM32MP1_CLKFUNC_H
#include <libfdt.h>
#include <stdbool.h>
enum stm32mp_osc_id {
@ -33,7 +34,7 @@ uint32_t fdt_rcc_read_addr(void);
int fdt_rcc_read_uint32_array(const char *prop_name,
uint32_t *array, uint32_t count);
int fdt_rcc_subnode_offset(const char *name);
const uint32_t *fdt_rcc_read_prop(const char *prop_name, int *lenp);
const fdt32_t *fdt_rcc_read_prop(const char *prop_name, int *lenp);
bool fdt_get_rcc_secure_status(void);
uintptr_t fdt_get_stgen_base(void);

2
plat/st/stm32mp1/bl2_io_storage.c
View file

@ -37,7 +37,7 @@ static io_block_spec_t gpt_block_spec = {
.length = 34 * MMC_BLOCK_SIZE, /* Size of GPT table */
};
uint32_t block_buffer[MMC_BLOCK_SIZE] __aligned(MMC_BLOCK_SIZE);
static uint32_t block_buffer[MMC_BLOCK_SIZE] __aligned(MMC_BLOCK_SIZE);
static const io_block_dev_spec_t mmc_block_dev_spec = {
/* It's used as temp buffer in block driver */

1
plat/st/stm32mp1/plat_image_load.c
View file

@ -5,6 +5,7 @@
*/
#include <desc_image_load.h>
#include <platform.h>
/*******************************************************************************
* This function flushes the data structures so that they are visible