Djam/arm-trusted-firmware
1
0
Fork 0
mirror of https://github.com/ARM-software/arm-trusted-firmware.git synced 2025-04-16 09:34:18 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(ufs): retry commands on unit attention

Browse source 
Unit Attention Condition (UAC) gets set on a warm reset. Sending any
command (other than INQUIRY and REPORT LUNs) clears UAC, so its good to
add some retries when UAC is encountered

Signed-off-by: Anand Saminathan <anans@google.com>
Change-Id: Ia03b916d68565d0f3d25086b7f6d8c51d557b64f
This commit is contained in:
Anand Saminathan 2022-09-28 02:37:28 +00:00
parent 58aebb6a53
commit 3d309556c7
2 changed files with 24 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
drivers/ufs/ufs.c
View file

@ -477,6 +477,7 @@ static int ufs_check_resp(utp_utrd_t *utrd, int trans_type)
{
utrd_header_t *hd;
resp_upiu_t *resp;
sense_data_t *sense;
unsigned int data;
int slot;
@ -499,6 +500,15 @@ static int ufs_check_resp(utp_utrd_t *utrd, int trans_type)
inv_dcache_range((uintptr_t)hd, UFS_DESC_SIZE);
assert(hd->ocs == OCS_SUCCESS);
assert((resp->trans_type & TRANS_TYPE_CODE_MASK) == trans_type);
sense = &resp->sd.sense;
if (sense->resp_code == SENSE_DATA_VALID &&
sense->sense_key == SENSE_KEY_UNIT_ATTENTION && sense->asc == 0x29 &&
sense->ascq == 0) {
WARN("Unit Attention Condition\n");
return -EAGAIN;
}
(void)resp;
(void)slot;
return 0;
@ -507,14 +517,18 @@ static int ufs_check_resp(utp_utrd_t *utrd, int trans_type)
static void ufs_send_cmd(utp_utrd_t *utrd, uint8_t cmd_op, uint8_t lun, int lba, uintptr_t buf,
size_t length)
{
int result;
int result, i;
get_utrd(utrd);
result = ufs_prepare_cmd(utrd, cmd_op, lun, lba, buf, length);
assert(result == 0);
ufs_send_request(utrd->task_tag);
result = ufs_check_resp(utrd, RESPONSE_UPIU);
for (i = 0; i < UFS_CMD_RETRIES; ++i) {
get_utrd(utrd);
result = ufs_prepare_cmd(utrd, cmd_op, lun, lba, buf, length);
assert(result == 0);
ufs_send_request(utrd->task_tag);
result = ufs_check_resp(utrd, RESPONSE_UPIU);
if (result == 0 || result == -EIO) {
break;
}
}
assert(result == 0);
(void)result;
}

3
include/drivers/ufs.h
View file

@ -259,6 +259,9 @@
/* maximum number of retries for a general UIC command */
#define UFS_UIC_COMMAND_RETRIES 3
/* maximum number of retries for a transfer command */
#define UFS_CMD_RETRIES 3
/* maximum number of retries for reading UFS capacity */
#define UFS_READ_CAPACITY_RETRIES 10