From 13cc1a506428398cc8cc142015dca10d24840f96 Mon Sep 17 00:00:00 2001 From: Yann Gautier Date: Mon, 4 Nov 2024 18:32:21 +0100 Subject: [PATCH] fix(st-ddr): move skipddc_dat definition The skipddc_dat variable is only use at one place in dfixlat_program() function. Move its definition and update there to avoid compilation issues about variables being set but not used. Signed-off-by: Yann Gautier Change-Id: I6b5273365f1da26773fc46f898362cb9af170506 --- .../src/ddrphy_phyinit_c_initphyconfig.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/st/ddr/phy/phyinit/src/ddrphy_phyinit_c_initphyconfig.c b/drivers/st/ddr/phy/phyinit/src/ddrphy_phyinit_c_initphyconfig.c index a0712b5fb..e5c82580f 100644 --- a/drivers/st/ddr/phy/phyinit/src/ddrphy_phyinit_c_initphyconfig.c +++ b/drivers/st/ddr/phy/phyinit/src/ddrphy_phyinit_c_initphyconfig.c @@ -761,17 +761,9 @@ static void dfixlat_program(struct stm32mp_ddr_config *config) { uint16_t loopvector; uint16_t pllbypass_dat = 0U; - uint16_t skipddc_dat = 0U; /* - * Set to vector offset based on frequency to disable dram - * drift compensation. - */ pllbypass_dat |= (uint16_t)config->uib.pllbypass; - if (config->uib.frequency < 333U) { - skipddc_dat |= 0x5U; - } - for (loopvector = 0U; loopvector < 8U; loopvector++) { uint16_t dfifreqxlat_dat; uintptr_t reg = (uintptr_t)(DDRPHYC_BASE + (4U * (C0 | TMASTER | @@ -799,6 +791,15 @@ static void dfixlat_program(struct stm32mp_ddr_config *config) } #else /* STM32MP_LPDDR4_TYPE */ if (loopvector == 0U) { + uint16_t skipddc_dat = 0U; /* + * Set to vector offset based on frequency + * to disable dram drift compensation. + */ + + if (config->uib.frequency < 333U) { + skipddc_dat |= 0x5U; + } + /* * Retrain & Relock DfiFreq = 00,01,02,03) Use StartVec 0 (pll_enabled) or * StartVec 1 (pll_bypassed).