diff --git a/docs/design/cpu-specific-build-macros.rst b/docs/design/cpu-specific-build-macros.rst index 463790859..0e5c7a05d 100644 --- a/docs/design/cpu-specific-build-macros.rst +++ b/docs/design/cpu-specific-build-macros.rst @@ -882,6 +882,9 @@ For Cortex-X4, the following errata build flags are defined : - ``ERRATA_X4_2923985``: This applies errata 2923985 workaround to Cortex-X4 CPU. This needs to be enabled for revisions r0p0 and r0p1. It is fixed in r0p2. +- ``ERRATA_X4_2957258``: This applies errata 2957258 workaround to Cortex-X4 + CPU. This needs to be enabled for revisions r0p0 and r0p1. It is fixed in r0p2. + - ``ERRATA_X4_3076789``: This applies errata 3076789 workaround to Cortex-X4 CPU. This needs to be enabled for revisions r0p0 and r0p1. It is fixed in r0p2. diff --git a/lib/cpus/aarch64/cortex_x4.S b/lib/cpus/aarch64/cortex_x4.S index fded73fe4..1e81892b1 100644 --- a/lib/cpus/aarch64/cortex_x4.S +++ b/lib/cpus/aarch64/cortex_x4.S @@ -89,6 +89,21 @@ workaround_reset_end cortex_x4, ERRATUM(2923985) check_erratum_ls cortex_x4, ERRATUM(2923985), CPU_REV(0, 1) +workaround_reset_start cortex_x4, ERRATUM(2957258), ERRATA_X4_2957258 + /* Add ISB before MRS reads of MPIDR_EL1/MIDR_EL1 */ + ldr x0, =0x1 + msr S3_6_c15_c8_0, x0 /* msr CPUPSELR_EL3, X0 */ + ldr x0, =0xd5380000 + msr S3_6_c15_c8_2, x0 /* msr CPUPOR_EL3, X0 */ + ldr x0, =0xFFFFFF40 + msr S3_6_c15_c8_3,x0 /* msr CPUPMR_EL3, X0 */ + ldr x0, =0x000080010033f + msr S3_6_c15_c8_1, x0 /* msr CPUPCR_EL3, X0 */ + isb +workaround_reset_end cortex_x4, ERRATUM(2957258) + +check_erratum_ls cortex_x4, ERRATUM(2957258), CPU_REV(0, 1) + workaround_reset_start cortex_x4, ERRATUM(3076789), ERRATA_X4_3076789 sysreg_bit_set CORTEX_X4_CPUACTLR3_EL1, BIT(14) sysreg_bit_set CORTEX_X4_CPUACTLR3_EL1, BIT(13) diff --git a/lib/cpus/cpu-ops.mk b/lib/cpus/cpu-ops.mk index 0db7e94ac..38abbc7ea 100644 --- a/lib/cpus/cpu-ops.mk +++ b/lib/cpus/cpu-ops.mk @@ -885,6 +885,12 @@ CPU_FLAG_LIST += ERRATA_X4_2897503 # to revisions r0p0 and r0p1 of the Cortex-X4 cpu. It is fixed in r0p2. CPU_FLAG_LIST += ERRATA_X4_2923985 +# Flag to apply erratum 2957258 workaround to avoid incorrect virtualization of +# MPIDR_EL1/VMPIDR_EL2 and MIDR_EL1/VPIDR_EL2 when reading in EL2/EL3. This +# erratum applies to revisions r0p0, r0p1 of the Cortex-X4 cpu. It is fixed +# in r0p2. +CPU_FLAG_LIST += ERRATA_X4_2957258 + # Flag to apply erratum 3076789 workaround on reset. This erratum applies # to revisions r0p0 and r0p1 of the Cortex-X4 cpu. It is fixed in r0p2. CPU_FLAG_LIST += ERRATA_X4_3076789