diff --git a/plat/amd/versal2/bl31_setup.c b/plat/amd/versal2/bl31_setup.c index 47d4c2ca1..6e7fffec5 100644 --- a/plat/amd/versal2/bl31_setup.c +++ b/plat/amd/versal2/bl31_setup.c @@ -63,7 +63,7 @@ static inline void bl31_set_default_config(void) bl32_image_ep_info.args.arg3 = XILINX_OF_BOARD_DTB_ADDR; #endif bl33_image_ep_info.pc = plat_get_ns_image_entrypoint(); - bl33_image_ep_info.spsr = SPSR_64(MODE_EL2, MODE_SP_ELX, + bl33_image_ep_info.spsr = (uint32_t)SPSR_64(MODE_EL2, MODE_SP_ELX, DISABLE_ALL_EXCEPTIONS); } @@ -229,7 +229,7 @@ void bl31_platform_setup(void) void bl31_plat_runtime_setup(void) { - uint64_t flags = 0; + uint32_t flags = 0; int32_t rc; set_interrupt_rm_flag(flags, NON_SECURE); diff --git a/plat/amd/versal2/plat_psci.c b/plat/amd/versal2/plat_psci.c index d49adf182..e8dc5d3d6 100644 --- a/plat/amd/versal2/plat_psci.c +++ b/plat/amd/versal2/plat_psci.c @@ -69,7 +69,7 @@ static int32_t zynqmp_nopmu_pwr_domain_on(u_register_t mpidr) mmio_write_32(apu_cluster_base + APU_RVBAR_L_0 + (cpu << 3), (uint32_t)_sec_entry); mmio_write_32(apu_cluster_base + APU_RVBAR_H_0 + (cpu << 3), - _sec_entry >> 32); + (uint32_t)(_sec_entry >> 32)); /* de-assert core reset */ mmio_clrbits_32(rst_apu_cluster, ((RST_APU_COLD_RESET|RST_APU_WARN_RESET) << cpu)); diff --git a/plat/amd/versal2/scmi.c b/plat/amd/versal2/scmi.c index fa0b2ca37..eec8205f9 100644 --- a/plat/amd/versal2/scmi.c +++ b/plat/amd/versal2/scmi.c @@ -328,7 +328,7 @@ int32_t plat_scmi_clock_set_rate(unsigned int agent_id, unsigned int scmi_id, unsigned long rate) { struct scmi_clk *clock = clk_find(agent_id, scmi_id); - unsigned long ret = UL(SCMI_SUCCESS); + int32_t ret = SCMI_SUCCESS; if ((clock == NULL)) { ret = SCMI_NOT_FOUND; @@ -564,17 +564,19 @@ int32_t plat_scmi_pd_set_state(unsigned int agent_id, unsigned int flags, unsign unsigned int state) { struct scmi_pd *pd = find_pd(agent_id, pd_id); + int32_t ret = SCMI_SUCCESS; if (pd == NULL) { - return SCMI_NOT_SUPPORTED; + ret = SCMI_NOT_SUPPORTED; + } else { + + NOTICE("SCMI: PD: set id: %d, orig state: %x, new state: %x, flags: %x\n", + pd_id, pd->state, state, flags); + + pd->state = state; } - NOTICE("SCMI: PD: set id: %d, orig state: %x, new state: %x, flags: %x\n", - pd_id, pd->state, state, flags); - - pd->state = state; - - return 0U; + return ret; }