Merge changes from topic "hikey960-el3-spmc" into integration

* changes:
  feat(hikey960): read serial number from UFS
  feat(hikey960): add a FF-A logical partition
  feat(hikey960): add memory sharing hooks for SPMC_AT_EL3
  feat(hikey960): add plat-defines for SPMC_AT_EL3
  feat(hikey960): define a datastore for SPMC_AT_EL3
  feat(hikey960): add SP manifest for SPMC_AT_EL3
  feat(hikey960): increase secure workspace to 64MB
  feat(hikey960): upgrade to xlat_tables_v2
This commit is contained in:
Olivier Deprez 2022-11-04 10:47:54 +01:00 committed by TrustedFirmware Code Review
commit 07217574af
12 changed files with 359 additions and 22 deletions

View file

@ -1,5 +1,5 @@
/*
* Copyright (c) 2017-2018, ARM Limited and Contributors. All rights reserved.
* Copyright (c) 2017-2022, ARM Limited and Contributors. All rights reserved.
*
* SPDX-License-Identifier: BSD-3-Clause
*/
@ -12,7 +12,7 @@
#include <common/bl_common.h>
#include <common/debug.h>
#include <lib/mmio.h>
#include <lib/xlat_tables/xlat_tables.h>
#include <lib/xlat_tables/xlat_tables_v2.h>
#include <plat/common/platform.h>
#include "../hikey960_def.h"
@ -69,7 +69,6 @@ static const mmap_region_t hikey960_mmap[] = {
#ifdef IMAGE_BL31
static const mmap_region_t hikey960_mmap[] = {
MAP_DEVICE,
MAP_TSP_MEM,
{0}
};
#endif

View file

@ -1,5 +1,5 @@
/*
* Copyright (c) 2016-2018, ARM Limited and Contributors. All rights reserved.
* Copyright (c) 2016-2022, ARM Limited and Contributors. All rights reserved.
*
* SPDX-License-Identifier: BSD-3-Clause
*/
@ -138,6 +138,22 @@ static bl_mem_params_node_t bl2_mem_params_descs[] = {
#endif
.next_handoff_image_id = INVALID_IMAGE_ID,
},
#ifdef SPD_spmd
/* Fill TOS_FW_CONFIG related information */
{
.image_id = TOS_FW_CONFIG_ID,
SET_STATIC_PARAM_HEAD(ep_info, PARAM_IMAGE_BINARY,
VERSION_2, entry_point_info_t, SECURE | NON_EXECUTABLE),
SET_STATIC_PARAM_HEAD(image_info, PARAM_IMAGE_BINARY,
VERSION_2, image_info_t, 0),
.image_info.image_base = DDR_SEC_CONFIG_BASE,
.image_info.image_max_size = DDR_SEC_CONFIG_SIZE,
.next_handoff_image_id = INVALID_IMAGE_ID,
},
#endif
# endif /* BL32_BASE */
/* Fill BL33 related information */

View file

@ -1,5 +1,5 @@
/*
* Copyright (c) 2017-2018, ARM Limited and Contributors. All rights reserved.
* Copyright (c) 2017-2022, ARM Limited and Contributors. All rights reserved.
*
* SPDX-License-Identifier: BSD-3-Clause
*/
@ -31,6 +31,9 @@
#define BL2_RW_BASE (BL_CODE_END)
/* BL2 platform parameters passed to BL31 */
static plat_params_from_bl2_t plat_params_from_bl2;
static meminfo_t bl2_el3_tzram_layout;
static console_t console;
extern int load_lpm3(void);
@ -217,6 +220,11 @@ int hikey960_bl2_handle_post_image_load(unsigned int image_id)
assert(bl_mem_params);
switch (image_id) {
case BL31_IMAGE_ID:
/* Pass BL2 platform parameter to BL31 */
bl_mem_params->ep_info.args.arg1 = (uint64_t) &plat_params_from_bl2;
break;
#ifdef __aarch64__
case BL32_IMAGE_ID:
#ifdef SPD_opteed
@ -307,6 +315,8 @@ void bl2_el3_plat_arch_setup(void)
void bl2_platform_setup(void)
{
int ret;
/* disable WDT0 */
if (mmio_read_32(WDT0_REG_BASE + WDT_LOCK_OFFSET) == WDT_LOCKED) {
mmio_write_32(WDT0_REG_BASE + WDT_LOCK_OFFSET, WDT_UNLOCK);
@ -322,4 +332,13 @@ void bl2_platform_setup(void)
hikey960_gpio_init();
hikey960_init_ufs();
hikey960_io_setup();
/* Read serial number from storage */
plat_params_from_bl2.fastboot_serno = 0;
ret = hikey960_load_serialno(&plat_params_from_bl2.fastboot_serno);
if (ret != 0) {
ERROR("BL2: could not read serial number\n");
}
INFO("BL2: fastboot_serno %lx\n", plat_params_from_bl2.fastboot_serno);
flush_dcache_range((uintptr_t)&plat_params_from_bl2, sizeof(plat_params_from_bl2_t));
}

View file

@ -1,5 +1,5 @@
/*
* Copyright (c) 2017, ARM Limited and Contributors. All rights reserved.
* Copyright (c) 2017-2022, ARM Limited and Contributors. All rights reserved.
*
* SPDX-License-Identifier: BSD-3-Clause
*/
@ -20,7 +20,9 @@
#include <drivers/console.h>
#include <drivers/generic_delay_timer.h>
#include <lib/mmio.h>
#include <lib/xlat_tables/xlat_tables_v2.h>
#include <plat/common/platform.h>
#include <services/el3_spmc_ffa_memory.h>
#include <hi3660.h>
#include <hisi_ipc.h>
@ -31,6 +33,9 @@ static entry_point_info_t bl32_ep_info;
static entry_point_info_t bl33_ep_info;
static console_t console;
/* fastboot serial number consumed by Kinibi SPD/LP for gpd.tee.deviceID. */
uint64_t fastboot_serno;
/******************************************************************************
* On a GICv2 system, the Group 1 secure interrupts are treated as Group 0
* interrupts.
@ -71,6 +76,7 @@ void bl31_early_platform_setup2(u_register_t arg0, u_register_t arg1,
{
unsigned int id, uart_base;
void *from_bl2;
plat_params_from_bl2_t *plat_params_from_bl2 = (plat_params_from_bl2_t *) arg1;
from_bl2 = (void *) arg0;
@ -89,6 +95,10 @@ void bl31_early_platform_setup2(u_register_t arg0, u_register_t arg1,
cci_init(CCI400_REG_BASE, cci_map, ARRAY_SIZE(cci_map));
cci_enable_snoop_dvm_reqs(MPIDR_AFFLVL1_VAL(read_mpidr_el1()));
/* Fastboot serial number passed from BL2 as a platform parameter */
fastboot_serno = plat_params_from_bl2->fastboot_serno;
INFO("BL31: fastboot_serno %lx\n", fastboot_serno);
/*
* Check params passed from BL2 should not be NULL,
*/
@ -119,6 +129,11 @@ void bl31_early_platform_setup2(u_register_t arg0, u_register_t arg1,
void bl31_plat_arch_setup(void)
{
#if SPMC_AT_EL3
mmap_add_region(DDR2_SEC_BASE, DDR2_SEC_BASE, DDR2_SEC_SIZE,
MT_MEMORY | MT_RW | MT_SECURE);
#endif
hikey960_init_mmu_el3(BL31_BASE,
BL31_LIMIT - BL31_BASE,
BL_CODE_BASE,
@ -156,6 +171,48 @@ static void hikey960_iomcu_dma_init(void)
}
}
#if SPMC_AT_EL3
/*
* On the hikey960 platform when using the EL3 SPMC implementation allocate the
* datastore for tracking shared memory descriptors in the RAM2 DRAM section
* to ensure sufficient storage can be allocated.
* Provide an implementation of the accessor method to allow the datastore
* details to be retrieved by the SPMC.
* The SPMC will take care of initializing the memory region.
*/
#define SPMC_SHARED_MEMORY_OBJ_SIZE (512 * 1024)
__section("ram2_region") uint8_t plat_spmc_shmem_datastore[SPMC_SHARED_MEMORY_OBJ_SIZE];
int plat_spmc_shmem_datastore_get(uint8_t **datastore, size_t *size)
{
*datastore = plat_spmc_shmem_datastore;
*size = SPMC_SHARED_MEMORY_OBJ_SIZE;
return 0;
}
/*
* Add dummy implementations of memory management related platform hooks.
* These can be used to implement platform specific functionality to support
* a memory sharing/lending operation.
*
* Note: The hooks must be located as part of the initial share request and
* final reclaim to prevent order dependencies with operations that may take
* place in the normal world without visibility of the SPMC.
*/
int plat_spmc_shmem_begin(struct ffa_mtd *desc)
{
return 0;
}
int plat_spmc_shmem_reclaim(struct ffa_mtd *desc)
{
return 0;
}
#endif
void bl31_platform_setup(void)
{
/* Initialize the GIC driver, cpu and distributor interfaces */

View file

@ -1,5 +1,5 @@
/*
* Copyright (c) 2017, ARM Limited and Contributors. All rights reserved.
* Copyright (c) 2017-2022, ARM Limited and Contributors. All rights reserved.
*
* SPDX-License-Identifier: BSD-3-Clause
*/
@ -21,15 +21,21 @@
#define HIKEY960_DRAM_ID 1
/*
* DDR for OP-TEE (32MB from 0x3E00000-0x3FFFFFFF) is divided in several
* DDR for TEE (80MB from 0x3E00000-0x43000FFF) is divided into several
* regions:
* - Secure DDR (default is the top 16MB) used by OP-TEE
* - SPMC manifest (4KB at the top) used by SPMC_AT_EL3 and the TEE
* - Datastore for SPMC_AT_EL3 (4MB at the top) used by BL31
* - Secure DDR (default is the top 60MB) used by OP-TEE
* - Non-secure DDR used by OP-TEE (shared memory and padding) (4MB)
* - Secure DDR (4MB aligned on 4MB) for OP-TEE's "Secure Data Path" feature
* - Non-secure DDR (8MB) reserved for OP-TEE's future use
*/
#define DDR_SEC_SIZE 0x01000000
#define DDR_SEC_SIZE 0x03C00000 /* reserve 60MB secure memory */
#define DDR_SEC_BASE 0x3F000000
#define DDR2_SEC_SIZE 0x00400000 /* SPMC_AT_EL3: 4MB for BL31 RAM2 */
#define DDR2_SEC_BASE 0x42C00000
#define DDR_SEC_CONFIG_SIZE 0x00001000 /* SPMC_AT_EL3: SPMC manifest */
#define DDR_SEC_CONFIG_BASE 0x43000000
#define DDR_SDP_SIZE 0x00400000
#define DDR_SDP_BASE (DDR_SEC_BASE - 0x400000 /* align */ - \
@ -50,4 +56,27 @@
#define HIKEY960_UFS_DATA_BASE 0x10000000
#define HIKEY960_UFS_DATA_SIZE 0x0A000000 /* 160MB */
#if defined(SPMC_AT_EL3)
/*
* Number of Secure Partitions supported.
* SPMC at EL3, uses this count to configure the maximum number of supported
* secure partitions.
*/
#define SECURE_PARTITION_COUNT 1
/*
* Number of Nwld Partitions supported.
* SPMC at EL3, uses this count to configure the maximum number of supported
* nwld partitions.
*/
#define NS_PARTITION_COUNT 1
/*
* Number of Logical Partitions supported.
* SPMC at EL3, uses this count to configure the maximum number of supported
* logical partitions.
*/
#define MAX_EL3_LP_DESCS_COUNT 1
#endif /* SPMC_AT_EL3 */
#endif /* HIKEY960_DEF_H */

View file

@ -0,0 +1,61 @@
/*
* Copyright (c) 2022, ARM Limited and Contributors. All rights reserved.
*
* SPDX-License-Identifier: BSD-3-Clause
*/
#include <common/debug.h>
#include <services/el3_spmc_logical_sp.h>
#include <services/ffa_svc.h>
#include <smccc_helpers.h>
#define LP_PARTITION_ID 0xC001
#define LP_UUID {0x47a3bf57, 0xe98e43ad, 0xb7db524f, 0x1588f4e3}
/* Our Logical SP currently only supports receipt of direct messaging. */
#define PARTITION_PROPERTIES FFA_PARTITION_DIRECT_REQ_RECV
static int32_t sp_init(void)
{
INFO("LSP: Init function called.\n");
return 0;
}
static uint64_t handle_ffa_direct_request(uint32_t smc_fid, bool secure_origin,
uint64_t x1, uint64_t x2, uint64_t x3,
uint64_t x4, void *cookie,
void *handle, uint64_t flags)
{
uint64_t ret;
/* Determine if we have a 64 or 32 direct request. */
if (smc_fid == FFA_MSG_SEND_DIRECT_REQ_SMC32) {
ret = FFA_MSG_SEND_DIRECT_RESP_SMC32;
} else if (smc_fid == FFA_MSG_SEND_DIRECT_REQ_SMC64) {
ret = FFA_MSG_SEND_DIRECT_RESP_SMC64;
} else {
panic(); /* Unknown SMC. */
}
/*
* Handle the incoming request. For testing purposes we echo the
* incoming message.
*/
INFO("Logical Partition: Received Direct Request from %s world!\n",
secure_origin ? "Secure" : "Normal");
/*
* Logical SP's must always send a direct response so we can populate
* our response directly.
*/
SMC_RET8(handle, ret, 0, 0, x4, 0, 0, 0, 0);
}
/* Register logical partition */
DECLARE_LOGICAL_PARTITION(
my_logical_partition,
sp_init, /* Init Function */
LP_PARTITION_ID, /* FF-A Partition ID */
LP_UUID, /* UUID */
PARTITION_PROPERTIES, /* Partition Properties. */
handle_ffa_direct_request /* Callback for direct requests. */
);

View file

@ -1,9 +1,10 @@
/*
* Copyright (c) 2017-2018, ARM Limited and Contributors. All rights reserved.
* Copyright (c) 2017-2022, ARM Limited and Contributors. All rights reserved.
*
* SPDX-License-Identifier: BSD-3-Clause
*/
#include <assert.h>
#include <common/bl_common.h>
#include <common/desc_image_load.h>
#include <plat/common/platform.h>
@ -25,10 +26,30 @@ bl_load_info_t *plat_get_bl_image_load_info(void)
return get_bl_load_info_from_mem_params_desc();
}
/*******************************************************************************
* ARM helper function to return the list of executable images. Since the default
* descriptors are allocated within BL2 RW memory, this prevents BL31/BL32
* overlay of BL2 memory. Hence this function also copies the descriptors to a
* pre-allocated memory indicated by ARM_BL2_MEM_DESC_BASE.
******************************************************************************/
struct bl_params *hikey960_get_next_bl_params(void)
{
bl_params_t *next_bl_params;
next_bl_params = get_next_bl_params_from_mem_params_desc();
assert(next_bl_params != NULL);
populate_next_bl_params_config(next_bl_params);
return next_bl_params;
}
/*******************************************************************************
* This function returns the list of executable images.
******************************************************************************/
bl_params_t *plat_get_next_bl_params(void)
{
return get_next_bl_params_from_mem_params_desc();
return hikey960_get_next_bl_params();
}

View file

@ -1,5 +1,5 @@
/*
* Copyright (c) 2017-2018, ARM Limited and Contributors. All rights reserved.
* Copyright (c) 2017-2022, ARM Limited and Contributors. All rights reserved.
*
* SPDX-License-Identifier: BSD-3-Clause
*/
@ -23,6 +23,9 @@
#include <lib/semihosting.h>
#include <tools_share/firmware_image_package.h>
#include "hikey960_def.h"
#include "hikey960_private.h"
struct plat_io_policy {
uintptr_t *dev_handle;
uintptr_t image_spec;
@ -45,6 +48,12 @@ static const io_block_spec_t ufs_gpt_spec = {
(PLAT_PARTITION_MAX_ENTRIES / 4 + 2),
};
/* Fastboot serial number stored within first UFS device blocks */
static const io_block_spec_t ufs_fastboot_spec = {
.offset = UFS_BASE,
.length = 1 << 20,
};
static const io_block_dev_spec_t ufs_dev_spec = {
/* It's used as temp buffer in block driver. */
.buffer = {
@ -78,6 +87,12 @@ static const io_uuid_spec_t bl32_extra2_uuid_spec = {
.uuid = UUID_SECURE_PAYLOAD_BL32_EXTRA2,
};
#ifdef SPD_spmd
static const io_uuid_spec_t bl32_tos_fw_spec = {
.uuid = UUID_TOS_FW_CONFIG,
};
#endif
static const io_uuid_spec_t bl33_uuid_spec = {
.uuid = UUID_NON_TRUSTED_FIRMWARE_BL33,
};
@ -151,6 +166,15 @@ static const struct plat_io_policy policies[] = {
(uintptr_t)&bl32_extra2_uuid_spec,
check_fip
},
#ifdef SPD_spmd
[TOS_FW_CONFIG_ID] = {
&fip_dev_handle,
(uintptr_t)&bl32_tos_fw_spec,
check_fip
},
#endif
[BL33_IMAGE_ID] = {
&fip_dev_handle,
(uintptr_t)&bl33_uuid_spec,
@ -241,6 +265,54 @@ static int check_fip(const uintptr_t spec)
return result;
}
int hikey960_load_serialno(uint64_t *serno)
{
int result;
size_t len = 0;
uintptr_t local_handle;
uint64_t buf[HIKEY960_SERIAL_NUMBER_SIZE / sizeof(uint64_t)];
if (serno == NULL) {
return -1;
}
result = io_dev_init(ufs_dev_handle, (uintptr_t)NULL);
if (result != 0) {
return result;
}
result = io_open(ufs_dev_handle,
(uintptr_t)&ufs_fastboot_spec, &local_handle);
if (result != 0) {
return result;
}
result = io_seek(local_handle, IO_SEEK_SET,
HIKEY960_SERIAL_NUMBER_LBA * UFS_BLOCK_SIZE);
if (result != 0) {
goto closing;
}
result = io_read(local_handle, (uintptr_t)buf,
HIKEY960_SERIAL_NUMBER_SIZE, &len);
if (result != 0) {
goto closing;
}
if (len != HIKEY960_SERIAL_NUMBER_SIZE) {
result = -1;
goto closing;
}
/* UEFI fastboot app stores a 16 bytes blob */
/* We extract only relevant 8 bytes serial number */
*serno = buf[1];
closing:
io_close(local_handle);
return result;
}
void hikey960_io_setup(void)
{
int result;

View file

@ -1,5 +1,5 @@
/*
* Copyright (c) 2017, ARM Limited and Contributors. All rights reserved.
* Copyright (c) 2017-2022, ARM Limited and Contributors. All rights reserved.
*
* SPDX-License-Identifier: BSD-3-Clause
*/
@ -9,6 +9,10 @@
#include <common/bl_common.h>
/* Fastboot serial number */
#define HIKEY960_SERIAL_NUMBER_LBA (UFS_BASE + 20)
#define HIKEY960_SERIAL_NUMBER_SIZE 16
/*
* Function and variable prototypes
*/
@ -27,6 +31,7 @@ void hikey960_init_mmu_el3(unsigned long total_base,
void hikey960_io_setup(void);
int hikey960_read_boardid(unsigned int *id);
int hikey960_set_fip_addr(unsigned int image_id, const char *name);
int hikey960_load_serialno(uint64_t *serno);
void hikey960_clk_init(void);
void hikey960_pmu_init(void);
void hikey960_regulator_enable(void);
@ -39,4 +44,12 @@ void clr_retention_ticks(unsigned int val);
void clr_ex(void);
void nop(void);
/*******************************************************************************
* Struct for parameters received from BL2
******************************************************************************/
typedef struct plat_params_from_bl2 {
/* Fastboot serial number gathered from UFS */
uint64_t fastboot_serno;
} plat_params_from_bl2_t;
#endif /* HIKEY960_PRIVATE_H */

View file

@ -0,0 +1,22 @@
/*
* Copyright (c) 2022, ARM Limited and Contributors. All rights reserved.
*
* SPDX-License-Identifier: BSD-3-Clause
*/
#ifndef PLAT_LD_S
#define PLAT_LD_S
#include <lib/xlat_tables/xlat_tables_defs.h>
MEMORY {
RAM2 (rw): ORIGIN = DDR2_SEC_BASE, LENGTH = DDR2_SEC_SIZE
}
SECTIONS
{
ram2_region (NOLOAD) : {
*(ram2_region)
}>RAM2
}
#endif /* PLAT_LD_S */

View file

@ -1,5 +1,5 @@
/*
* Copyright (c) 2017-2019, ARM Limited and Contributors. All rights reserved.
* Copyright (c) 2017-2022, ARM Limited and Contributors. All rights reserved.
*
* SPDX-License-Identifier: BSD-3-Clause
*/
@ -114,15 +114,23 @@
/*
* Platform specific page table and MMU setup constants
*/
#define PLAT_VIRT_ADDR_SPACE_SIZE (1ULL << 32)
#define PLAT_PHY_ADDR_SPACE_SIZE (1ULL << 32)
#define PLAT_VIRT_ADDR_SPACE_SIZE (1ULL << 36)
#define PLAT_PHY_ADDR_SPACE_SIZE (1ULL << 36)
#if defined(IMAGE_BL1) || defined(IMAGE_BL31) || defined(IMAGE_BL32)
#if defined(IMAGE_BL1) || defined(IMAGE_BL32)
#define MAX_XLAT_TABLES 3
#endif
#ifdef IMAGE_BL2
#define MAX_XLAT_TABLES 4
#if defined(IMAGE_BL2)
#define MAX_XLAT_TABLES 5
#endif
#if defined(IMAGE_BL31)
#if defined(SPMC_AT_EL3)
#define MAX_XLAT_TABLES 17
#else
#define MAX_XLAT_TABLES 5
#endif
#endif
#define MAX_MMAP_REGIONS 16

View file

@ -46,11 +46,12 @@ PLAT_INCLUDES := -Iplat/hisilicon/hikey960/include
PLAT_BL_COMMON_SOURCES := drivers/arm/pl011/aarch64/pl011_console.S \
drivers/delay_timer/delay_timer.c \
drivers/delay_timer/generic_delay_timer.c \
lib/xlat_tables/aarch64/xlat_tables.c \
lib/xlat_tables/xlat_tables_common.c \
plat/hisilicon/hikey960/aarch64/hikey960_common.c \
plat/hisilicon/hikey960/hikey960_boardid.c
include lib/xlat_tables_v2/xlat_tables.mk
PLAT_BL_COMMON_SOURCES += ${XLAT_TABLES_LIB_SRCS}
HIKEY960_GIC_SOURCES := drivers/arm/gic/common/gic_common.c \
drivers/arm/gic/v2/gicv2_main.c \
drivers/arm/gic/v2/gicv2_helpers.c \
@ -160,3 +161,22 @@ ERRATA_A53_843419 := 1
ERRATA_A53_855873 := 1
FIP_ALIGN := 512
# SPM dispatcher
ifeq (${SPD},spmd)
ifeq (${SPMC_AT_EL3},1)
# include device tree helper library
include lib/libfdt/libfdt.mk
BL31_SOURCES += common/fdt_wrappers.c \
${LIBFDT_SRCS} \
common/uuid.c
# Add support for platform supplied linker script for BL31 build
$(eval $(call add_define,PLAT_EXTRA_LD_SCRIPT))
endif
ifeq ($(PLAT_SP_MANIFEST_DTS),)
$(error "Error: A SP manifest is required for the SPMC.")
endif
FDT_SOURCES += ${PLAT_SP_MANIFEST_DTS}
endif